Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/net/npf Use uint8_t instead of npf_netmask_t, as npf_net...



details:   https://anonhg.NetBSD.org/src/rev/bc7f24458ac5
branches:  trunk
changeset: 770959:bc7f24458ac5
user:      jakllsch <jakllsch%NetBSD.org@localhost>
date:      Fri Nov 04 02:57:28 2011 +0000

description:
Use uint8_t instead of npf_netmask_t, as npf_netmask_t is a uint_fast8_t,
which is in many places is actually a uint32_t and thus incompatible with
prop_dictionary_get_uint8().  The correct type is noted in a comment.

diffstat:

 sys/net/npf/npf_ctl.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 25f7e42742e6 -r bc7f24458ac5 sys/net/npf/npf_ctl.c
--- a/sys/net/npf/npf_ctl.c     Fri Nov 04 02:25:31 2011 +0000
+++ b/sys/net/npf/npf_ctl.c     Fri Nov 04 02:57:28 2011 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: npf_ctl.c,v 1.7 2011/11/04 01:00:27 zoltan Exp $       */
+/*     $NetBSD: npf_ctl.c,v 1.8 2011/11/04 02:57:28 jakllsch Exp $     */
 
 /*-
  * Copyright (c) 2009-2011 The NetBSD Foundation, Inc.
@@ -37,7 +37,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: npf_ctl.c,v 1.7 2011/11/04 01:00:27 zoltan Exp $");
+__KERNEL_RCSID(0, "$NetBSD: npf_ctl.c,v 1.8 2011/11/04 02:57:28 jakllsch Exp $");
 
 #include <sys/param.h>
 #include <sys/conf.h>
@@ -121,7 +121,7 @@
                eit = prop_array_iterator(entries);
                while ((ent = prop_object_iterator_next(eit)) != NULL) {
                        const npf_addr_t *addr;
-                       npf_netmask_t mask;
+                       uint8_t mask; /* XXX should be npf_netmask_t */
 
                        /* Get address and mask.  Add a table entry. */
                        addr = (const npf_addr_t *)prop_data_data_nocopy(prop_dictionary_get(ent, "addr"));



Home | Main Index | Thread Index | Old Index