[src/trunk]: src/tests/fs/union Improve previous a bit more: now it works cor...

[pooka <pooka%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/a5d46a0053c0
branches:  trunk
changeset: 756027:a5d46a0053c0
user:      pooka <pooka%NetBSD.org@localhost>
date:      Sat Jul 03 13:37:22 2010 +0000

description:
Improve previous a bit more: now it works correctly in all cases
with or without xfail.

There is still room for improvement, though: with xfail the
errno != EROFS branch does not report why open failed.

diffstat:

 tests/fs/union/t_pr.c |  9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diffs (26 lines):

diff -r 70f89165ae25 -r a5d46a0053c0 tests/fs/union/t_pr.c
--- a/tests/fs/union/t_pr.c     Sat Jul 03 13:32:36 2010 +0000
+++ b/tests/fs/union/t_pr.c     Sat Jul 03 13:37:22 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: t_pr.c,v 1.6 2010/07/03 12:23:04 pooka Exp $   */
+/*     $NetBSD: t_pr.c,v 1.7 2010/07/03 13:37:22 pooka Exp $   */
 
 #include <sys/types.h>
 #include <sys/mount.h>
@@ -81,12 +81,13 @@
        fd = rump_sys_open("/mp/null", O_WRONLY | O_CREAT | O_TRUNC);
 
        atf_tc_expect_fail("PR kern/43560");
-       if (fd == -1 && errno == EROFS)
+       if (fd == -1 && errno == EROFS) {
                atf_tc_fail("open returned EROFS");
-       else if (fd == -1)
+       } else if (fd == -1) {
+               atf_tc_expect_pass();
                atf_tc_fail_errno("open fail");
+       }
 
-       atf_tc_expect_pass();
 }
 
 ATF_TC(devnull2);