Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic Fix logic error in detecting length of DDR3 SPD c...



details:   https://anonhg.NetBSD.org/src/rev/e0361c935012
branches:  trunk
changeset: 755928:e0361c935012
user:      pgoyette <pgoyette%NetBSD.org@localhost>
date:      Tue Jun 29 04:42:30 2010 +0000

description:
Fix logic error in detecting length of DDR3 SPD covered by CRC check.

Reported by Jonathan Gray in private email - thanks!

diffstat:

 sys/dev/ic/spdmem.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r d31318b86201 -r e0361c935012 sys/dev/ic/spdmem.c
--- a/sys/dev/ic/spdmem.c       Tue Jun 29 04:16:25 2010 +0000
+++ b/sys/dev/ic/spdmem.c       Tue Jun 29 04:42:30 2010 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: spdmem.c,v 1.1 2010/03/24 00:31:41 pgoyette Exp $ */
+/* $NetBSD: spdmem.c,v 1.2 2010/06/29 04:42:30 pgoyette Exp $ */
 
 /*
  * Copyright (c) 2007 Nicolas Joly
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: spdmem.c,v 1.1 2010/03/24 00:31:41 pgoyette Exp $");
+__KERNEL_RCSID(0, "$NetBSD: spdmem.c,v 1.2 2010/06/29 04:42:30 pgoyette Exp $");
 
 #include <sys/param.h>
 #include <sys/device.h>
@@ -177,7 +177,7 @@
        /* For DDR3 and FBDIMM, verify the CRC */
        else if (spd_type <= SPDMEM_MEMTYPE_DDR3SDRAM) {
                spd_len = (sc->sc_read)(sc, 0);
-               if (spd_len && SPDMEM_SPDCRC_116)
+               if (spd_len & SPDMEM_SPDCRC_116)
                        spd_crc_cover = 116;
                else
                        spd_crc_cover = 125;



Home | Main Index | Thread Index | Old Index