Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/acpi Remove PNP0C01 and PNP0C02 from the list of ign...



details:   https://anonhg.NetBSD.org/src/rev/bcbb9c2c4fe3
branches:  trunk
changeset: 755995:bcbb9c2c4fe3
user:      jruoho <jruoho%NetBSD.org@localhost>
date:      Fri Jul 02 05:18:38 2010 +0000

description:
Remove PNP0C01 and PNP0C02 from the list of ignored HIDs (and CIDs).

Fixes PR kern/42937 from Ryo Onodera.

As acpi_match_hid() matches also "compatible IDs" (CIDs), we must be careful
when adding devices to this list. For example, the above PR revealed that
the following is a fairly typical way to define the HPET device:

   Device (HPET)
                 {
                     Name (_HID, EisaId ("PNP0103"))
                     Name (_CID, EisaId ("PNP0C01"))
                                ...

Arguably this is a BIOS bug, given that PNP0C01 and PNP0C02 should uniquely
identify a device (or a resource template) that has nothing to do with HPET.

diffstat:

 sys/dev/acpi/acpi.c |  6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diffs (27 lines):

diff -r ff55d6993063 -r bcbb9c2c4fe3 sys/dev/acpi/acpi.c
--- a/sys/dev/acpi/acpi.c       Fri Jul 02 05:00:48 2010 +0000
+++ b/sys/dev/acpi/acpi.c       Fri Jul 02 05:18:38 2010 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: acpi.c,v 1.204 2010/07/02 05:00:48 jruoho Exp $        */
+/*     $NetBSD: acpi.c,v 1.205 2010/07/02 05:18:38 jruoho Exp $        */
 
 /*-
  * Copyright (c) 2003, 2007 The NetBSD Foundation, Inc.
@@ -65,7 +65,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: acpi.c,v 1.204 2010/07/02 05:00:48 jruoho Exp $");
+__KERNEL_RCSID(0, "$NetBSD: acpi.c,v 1.205 2010/07/02 05:18:38 jruoho Exp $");
 
 #include "opt_acpi.h"
 #include "opt_pcifixup.h"
@@ -144,8 +144,6 @@
        "PNP0200",      /* AT DMA controller is handled internally */
        "PNP0A??",      /* PCI Busses are handled internally */
        "PNP0B00",      /* AT RTC is handled internally */
-       "PNP0C01",      /* No "System Board" driver */
-       "PNP0C02",      /* No "PnP motherboard register resources" driver */
        "PNP0C0B",      /* No need for "ACPI fan" driver */
        "PNP0C0F",      /* ACPI PCI link devices are handled internally */
        "IFX0102",      /* No driver for Infineon TPM */



Home | Main Index | Thread Index | Old Index