Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Minor comment fix. Use fd_close() in sys__ksem_des...



details:   https://anonhg.NetBSD.org/src/rev/e51c3c6f3cf8
branches:  trunk
changeset: 764196:e51c3c6f3cf8
user:      rmind <rmind%NetBSD.org@localhost>
date:      Thu Apr 14 00:32:23 2011 +0000

description:
Minor comment fix.  Use fd_close() in sys__ksem_destroy(), it is cleaner.

diffstat:

 sys/kern/uipc_sem.c |  12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diffs (48 lines):

diff -r b7c8a736f65d -r e51c3c6f3cf8 sys/kern/uipc_sem.c
--- a/sys/kern/uipc_sem.c       Wed Apr 13 23:31:25 2011 +0000
+++ b/sys/kern/uipc_sem.c       Thu Apr 14 00:32:23 2011 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uipc_sem.c,v 1.31 2011/04/12 20:37:25 rmind Exp $      */
+/*     $NetBSD: uipc_sem.c,v 1.32 2011/04/14 00:32:23 rmind Exp $      */
 
 /*-
  * Copyright (c) 2011 The NetBSD Foundation, Inc.
@@ -60,7 +60,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_sem.c,v 1.31 2011/04/12 20:37:25 rmind Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_sem.c,v 1.32 2011/04/14 00:32:23 rmind Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -460,7 +460,7 @@
                }
 
                /*
-                * Finally, insert semaphore into the hash.
+                * Finally, insert semaphore into the list.
                 * Note: it already has the initial reference.
                 */
                ks = ksnew;
@@ -676,7 +676,6 @@
                intptr_t id;
        } */
        int fd = (int)SCARG(uap, id), error;
-       struct sys_close_args cuap;
        ksem_t *ks;
 
        error = ksem_get(fd, &ks);
@@ -697,10 +696,9 @@
        }
 out:
        mutex_exit(&ks->ks_lock);
-       fd_putfile(fd);
        if (error) {
+               fd_putfile(fd);
                return error;
        }
-       SCARG(&cuap, fd) = fd;
-       return sys_close(l, (const void *)&cuap, retval);
+       return fd_close(fd);
 }



Home | Main Index | Thread Index | Old Index