[src/trunk]: src/sys/dev/acpi After a closer examination, remove entirely the...

[jruoho <jruoho%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/105bdd9e5a40
branches:  trunk
changeset: 762533:105bdd9e5a40
user:      jruoho <jruoho%NetBSD.org@localhost>
date:      Tue Feb 22 16:05:30 2011 +0000

description:
After a closer examination, remove entirely the check that was considered in
the revision 1.38. As noted in the specification (ACPI 4.0, p. 314):

  The platform must expose a _CST object for either all or none of its
  processors. If the _CST object exists, OSPM uses the C state information
  specified in the _CST object in lieu of P_LVL2 and P_LVL3 registers
  defined in P_BLK and the P_LVLx_LAT values defined in the FADT.

The _CST is seemingly valid on the system under consideration:

        Name (_CST, Package (0x02)
        {
            0x01,
            Package (0x04)
            {
                ResourceTemplate ()
                {
                    Register (SystemIO,
                        0x08,               // Bit Width
                        0x00,               // Bit Offset
                        0x000000000000F800, // Address
                        0x01,               // Access Size
                        )
                },

                0x02,
                0x0064,
                0x00000000
            }
        })

The check was also unnecessary in the sense that ACPI doesn't use bus_space(9).

diffstat:

 sys/dev/acpi/acpi_cpu_cstate.c |  19 ++-----------------
 1 files changed, 2 insertions(+), 17 deletions(-)

diffs (40 lines):

diff -r f8fdd292df44 -r 105bdd9e5a40 sys/dev/acpi/acpi_cpu_cstate.c
--- a/sys/dev/acpi/acpi_cpu_cstate.c    Tue Feb 22 15:51:59 2011 +0000
+++ b/sys/dev/acpi/acpi_cpu_cstate.c    Tue Feb 22 16:05:30 2011 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: acpi_cpu_cstate.c,v 1.39 2011/02/22 09:39:48 jruoho Exp $ */
+/* $NetBSD: acpi_cpu_cstate.c,v 1.40 2011/02/22 16:05:30 jruoho Exp $ */
 
 /*-
  * Copyright (c) 2010 Jukka Ruohonen <jruohonen%iki.fi@localhost>
@@ -27,7 +27,7 @@
  * SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: acpi_cpu_cstate.c,v 1.39 2011/02/22 09:39:48 jruoho Exp $");
+__KERNEL_RCSID(0, "$NetBSD: acpi_cpu_cstate.c,v 1.40 2011/02/22 16:05:30 jruoho Exp $");
 
 #include <sys/param.h>
 #include <sys/cpu.h>
@@ -423,21 +423,6 @@
                        goto out;
                }
 
-               /*
-                * Check only that the address is in the mapped space.
-                * Systems are allowed to change it when operating
-                * with _CST (see ACPI 4.0, pp. 94-95). For instance,
-                * the offset of P_LVL3 may change depending on whether
-                * acpiacad(4) is connected or disconnected.
-                */
-               if (ao->ao_pblkaddr != 0) {
-
-                       if (reg->reg_addr > ao->ao_pblkaddr + ao->ao_pblklen) {
-                               rv = AE_BAD_ADDRESS;
-                               goto out;
-                       }
-               }
-
                state.cs_addr = reg->reg_addr;
                break;