Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/crypto/dist/ipsec-tools/src/racoon fixed a memory leak in oa...



details:   https://anonhg.NetBSD.org/src/rev/5a9ed09014df
branches:  trunk
changeset: 763316:5a9ed09014df
user:      vanhu <vanhu%NetBSD.org@localhost>
date:      Thu Mar 17 14:35:24 2011 +0000

description:
fixed a memory leak in oakley_check_certid(). patch by Roman Hoog Antink <rha%open.ch@localhost>

diffstat:

 crypto/dist/ipsec-tools/src/racoon/oakley.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (30 lines):

diff -r 005a29efaa6f -r 5a9ed09014df crypto/dist/ipsec-tools/src/racoon/oakley.c
--- a/crypto/dist/ipsec-tools/src/racoon/oakley.c       Thu Mar 17 14:06:29 2011 +0000
+++ b/crypto/dist/ipsec-tools/src/racoon/oakley.c       Thu Mar 17 14:35:24 2011 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: oakley.c,v 1.19 2011/02/20 17:32:02 tteras Exp $       */
+/*     $NetBSD: oakley.c,v 1.20 2011/03/17 14:35:24 vanhu Exp $        */
 
 /* Id: oakley.c,v 1.32 2006/05/26 12:19:46 manubsd Exp */
 
@@ -1862,10 +1862,11 @@
                hints.ai_socktype = SOCK_RAW;
                hints.ai_flags = AI_NUMERICHOST;
                error = getaddrinfo(altname, NULL, &hints, &res);
+               racoon_free(altname);
+               altname = NULL;
                if (error != 0) {
                        plog(LLV_ERROR, LOCATION, NULL,
                                "no proper subjectAltName.\n");
-                       racoon_free(altname);
                        return ISAKMP_NTYPE_INVALID_CERTIFICATE;
                }
                switch (res->ai_family) {
@@ -1880,7 +1881,6 @@
                default:
                        plog(LLV_ERROR, LOCATION, NULL,
                                "family not supported: %d.\n", res->ai_family);
-                       racoon_free(altname);
                        freeaddrinfo(res);
                        return ISAKMP_NTYPE_INVALID_CERTIFICATE;
                }



Home | Main Index | Thread Index | Old Index