Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Turn off pipe's direct I/O again, it corrupts the d...



details:   https://anonhg.NetBSD.org/src/rev/93b58b458f4a
branches:  trunk
changeset: 747072:93b58b458f4a
user:      rmind <rmind%NetBSD.org@localhost>
date:      Mon Aug 31 20:48:14 2009 +0000

description:
Turn off pipe's direct I/O again, it corrupts the data (although build and
various activity survived while testing this).  Corruptions also happen on
sparc64 where emap is not in effect, therefore bugs are in direct I/O code.

diffstat:

 sys/kern/sys_pipe.c |  7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diffs (28 lines):

diff -r 26c21f7f5483 -r 93b58b458f4a sys/kern/sys_pipe.c
--- a/sys/kern/sys_pipe.c       Mon Aug 31 19:06:25 2009 +0000
+++ b/sys/kern/sys_pipe.c       Mon Aug 31 20:48:14 2009 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: sys_pipe.c,v 1.118 2009/08/29 00:06:43 rmind Exp $     */
+/*     $NetBSD: sys_pipe.c,v 1.119 2009/08/31 20:48:14 rmind Exp $     */
 
 /*-
  * Copyright (c) 2003, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -68,7 +68,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sys_pipe.c,v 1.118 2009/08/29 00:06:43 rmind Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sys_pipe.c,v 1.119 2009/08/31 20:48:14 rmind Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -99,6 +99,9 @@
  * #define PIPE_NODIRECT
  */
 
+/* XXX Disabled for now; rare hangs switching between direct/buffered */        
+#define PIPE_NODIRECT
+
 static int     pipe_read(file_t *, off_t *, struct uio *, kauth_cred_t, int);
 static int     pipe_write(file_t *, off_t *, struct uio *, kauth_cred_t, int);
 static int     pipe_close(file_t *);



Home | Main Index | Thread Index | Old Index