Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-2-0]: src/sys/dev/pci Pull up revision 1.67 (requested by jonatha...



details:   https://anonhg.NetBSD.org/src/rev/f0db0aa7dd73
branches:  netbsd-2-0
changeset: 560256:f0db0aa7dd73
user:      tron <tron%NetBSD.org@localhost>
date:      Mon Apr 05 20:47:05 2004 +0000

description:
Pull up revision 1.67 (requested by jonathan in ticket #59):
Fix mistaken arguments to bge_set_thresh(); the prior revision would
pass the bge_softc * to a function expecting the struct ifnet*,
triggering a panic every time the Rx-mitigation value is changed via sysctl.
(Testing via kernel debugger before Andrew's recent sysctl(9) changes
was done with the exact same mistaken argument.)

diffstat:

 sys/dev/pci/if_bge.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (32 lines):

diff -r 9f11bd472992 -r f0db0aa7dd73 sys/dev/pci/if_bge.c
--- a/sys/dev/pci/if_bge.c      Mon Apr 05 20:43:39 2004 +0000
+++ b/sys/dev/pci/if_bge.c      Mon Apr 05 20:47:05 2004 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_bge.c,v 1.66 2004/03/27 04:37:59 atatat Exp $       */
+/*     $NetBSD: if_bge.c,v 1.66.2.1 2004/04/05 20:47:05 tron Exp $     */
 
 /*
  * Copyright (c) 2001 Wind River Systems
@@ -79,7 +79,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_bge.c,v 1.66 2004/03/27 04:37:59 atatat Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_bge.c,v 1.66.2.1 2004/04/05 20:47:05 tron Exp $");
 
 #include "bpfilter.h"
 #include "vlan.h"
@@ -643,11 +643,11 @@
         * Now search all the interfaces for this name/number
         */
        TAILQ_FOREACH(ifp, &ifnet, if_list) {
-               if (strncmp(ifp->if_xname, namebuf, namelen) != 0 ) 
+               if (strncmp(ifp->if_xname, namebuf, namelen) != 0)
                      continue;
                /* We got a match: update if doing auto-threshold-tuning */
                if (bge_auto_thresh)
-                       bge_set_thresh(ifp->if_softc, lvl);
+                       bge_set_thresh(ifp, lvl);
        }
 }
 



Home | Main Index | Thread Index | Old Index