Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sbin/scsictl Increase the SCSI command timeout for device st...



details:   https://anonhg.NetBSD.org/src/rev/e403b4028633
branches:  trunk
changeset: 567110:e403b4028633
user:      fair <fair%NetBSD.org@localhost>
date:      Tue Jun 01 02:40:00 2004 +0000

description:
Increase the SCSI command timeout for device start & stop from 10
to 30 seconds, per PR 25734. I've seen this problem myself. I think
that scsictl should:

1. accept a timeout flag/parameter to set the timeout to an arbitrary
value other than the default.

2. support a verbose mode that would report the timeout value before
the command is started, and then report how long the command actually
took to complete, though I suppose the latter could also be done
by using time(1).

diffstat:

 sbin/scsictl/scsictl.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (36 lines):

diff -r fafec45c536c -r e403b4028633 sbin/scsictl/scsictl.c
--- a/sbin/scsictl/scsictl.c    Tue Jun 01 02:25:09 2004 +0000
+++ b/sbin/scsictl/scsictl.c    Tue Jun 01 02:40:00 2004 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: scsictl.c,v 1.23 2004/01/05 23:23:33 jmmv Exp $        */
+/*     $NetBSD: scsictl.c,v 1.24 2004/06/01 02:40:00 fair Exp $        */
 
 /*-
  * Copyright (c) 1998, 2002 The NetBSD Foundation, Inc.
@@ -43,7 +43,7 @@
 #include <sys/cdefs.h>
 
 #ifndef lint
-__RCSID("$NetBSD: scsictl.c,v 1.23 2004/01/05 23:23:33 jmmv Exp $");
+__RCSID("$NetBSD: scsictl.c,v 1.24 2004/06/01 02:40:00 fair Exp $");
 #endif
 
 
@@ -807,7 +807,7 @@
        cmd.opcode = START_STOP;
        cmd.how = SSS_START;
 
-       scsi_command(fd, &cmd, sizeof(cmd), NULL, 0, 10000, 0);
+       scsi_command(fd, &cmd, sizeof(cmd), NULL, 0, 30000, 0);
 
        return;
 }
@@ -833,7 +833,7 @@
        cmd.opcode = START_STOP;
        cmd.how = SSS_STOP;
 
-       scsi_command(fd, &cmd, sizeof(cmd), NULL, 0, 10000, 0);
+       scsi_command(fd, &cmd, sizeof(cmd), NULL, 0, 30000, 0);
 
        return;
 }



Home | Main Index | Thread Index | Old Index