Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Correct buffer selection in uhidev_set_report fo...



details:   https://anonhg.NetBSD.org/src/rev/45474cd406a5
branches:  trunk
changeset: 557201:45474cd406a5
user:      dsainty <dsainty%NetBSD.org@localhost>
date:      Sun Jan 04 02:13:11 2004 +0000

description:
Correct buffer selection in uhidev_set_report for non-zero report IDs (rare!)

Spotted by Dave Huang, noted in tech-kern.

diffstat:

 sys/dev/usb/uhidev.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 21e2973810a7 -r 45474cd406a5 sys/dev/usb/uhidev.c
--- a/sys/dev/usb/uhidev.c      Sun Jan 04 01:47:35 2004 +0000
+++ b/sys/dev/usb/uhidev.c      Sun Jan 04 02:13:11 2004 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uhidev.c,v 1.17 2004/01/04 01:29:11 augustss Exp $     */
+/*     $NetBSD: uhidev.c,v 1.18 2004/01/04 02:13:11 dsainty Exp $      */
 
 /*
  * Copyright (c) 2001 The NetBSD Foundation, Inc.
@@ -42,7 +42,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uhidev.c,v 1.17 2004/01/04 01:29:11 augustss Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uhidev.c,v 1.18 2004/01/04 02:13:11 dsainty Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -514,7 +514,7 @@
        memcpy(buf+1, data, len);
 
        retstat = usbd_set_report(scd->sc_parent->sc_iface, type,
-                                 scd->sc_report_id, data, len + 1);
+                                 scd->sc_report_id, buf, len + 1);
 
        free(buf, M_TEMP);
 



Home | Main Index | Thread Index | Old Index