[src/trunk]: src/sys/dev/raidframe Let's see... raidPtr->recon_done_procs is...

[oster <oster%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/bb7156f038c2
branches:  trunk
changeset: 556867:bb7156f038c2
user:      oster <oster%NetBSD.org@localhost>
date:      Mon Dec 29 05:58:34 2003 +0000

description:
Let's see...  raidPtr->recon_done_procs is never set to anything
(other than NULL when raidPtr is initialized).  That means
SignalReconDone() never does anything useful.  Bye-bye!

Say good-bye to recon_done_procs and recon_done_procs_mutex (and its
initializer) as well.

diffstat:

 sys/dev/raidframe/rf_driver.c      |   6 ++----
 sys/dev/raidframe/rf_raid.h        |   5 ++---
 sys/dev/raidframe/rf_reconstruct.c |  17 ++---------------
 3 files changed, 6 insertions(+), 22 deletions(-)

diffs (91 lines):

diff -r 05af75f6d801 -r bb7156f038c2 sys/dev/raidframe/rf_driver.c
--- a/sys/dev/raidframe/rf_driver.c     Mon Dec 29 05:52:58 2003 +0000
+++ b/sys/dev/raidframe/rf_driver.c     Mon Dec 29 05:58:34 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: rf_driver.c,v 1.77 2003/12/29 05:52:58 oster Exp $     */
+/*     $NetBSD: rf_driver.c,v 1.78 2003/12/29 05:58:34 oster Exp $     */
 /*-
  * Copyright (c) 1999 The NetBSD Foundation, Inc.
  * All rights reserved.
@@ -73,7 +73,7 @@
 
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: rf_driver.c,v 1.77 2003/12/29 05:52:58 oster Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rf_driver.c,v 1.78 2003/12/29 05:58:34 oster Exp $");
 
 #include "opt_raid_diagnostic.h"
 
@@ -371,8 +371,6 @@
 
        raidPtr->waitForReconCond = 0;
 
-       DO_RAID_MUTEX(&raidPtr->recon_done_proc_mutex);
-
        if (ac!=NULL) {
                /* We have an AutoConfig structure..  Don't do the
                   normal disk configuration... call the auto config
diff -r 05af75f6d801 -r bb7156f038c2 sys/dev/raidframe/rf_raid.h
--- a/sys/dev/raidframe/rf_raid.h       Mon Dec 29 05:52:58 2003 +0000
+++ b/sys/dev/raidframe/rf_raid.h       Mon Dec 29 05:58:34 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: rf_raid.h,v 1.19 2003/12/29 02:38:18 oster Exp $       */
+/*     $NetBSD: rf_raid.h,v 1.20 2003/12/29 05:58:34 oster Exp $       */
 /*
  * Copyright (c) 1995 Carnegie-Mellon University.
  * All rights reserved.
@@ -239,8 +239,7 @@
        int     numFullReconBuffers;
        RF_AccTraceEntry_t *recon_tracerecs;
        unsigned long accumXorTimeUs;
-       RF_ReconDoneProc_t *recon_done_procs;
-               RF_DECLARE_MUTEX(recon_done_proc_mutex)
+
        /*
          * nAccOutstanding, waitShutdown protected by desc freelist lock
          * (This may seem strange, since that's a central serialization point
diff -r 05af75f6d801 -r bb7156f038c2 sys/dev/raidframe/rf_reconstruct.c
--- a/sys/dev/raidframe/rf_reconstruct.c        Mon Dec 29 05:52:58 2003 +0000
+++ b/sys/dev/raidframe/rf_reconstruct.c        Mon Dec 29 05:58:34 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: rf_reconstruct.c,v 1.58 2003/12/29 03:33:48 oster Exp $        */
+/*     $NetBSD: rf_reconstruct.c,v 1.59 2003/12/29 05:58:34 oster Exp $        */
 /*
  * Copyright (c) 1995 Carnegie-Mellon University.
  * All rights reserved.
@@ -33,7 +33,7 @@
  ************************************************************/
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: rf_reconstruct.c,v 1.58 2003/12/29 03:33:48 oster Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rf_reconstruct.c,v 1.59 2003/12/29 05:58:34 oster Exp $");
 
 #include <sys/time.h>
 #include <sys/buf.h>
@@ -138,18 +138,6 @@
        RF_ReconDoneProc_t *next;
 };
 
-static void 
-SignalReconDone(RF_Raid_t * raidPtr)
-{
-       RF_ReconDoneProc_t *p;
-
-       RF_LOCK_MUTEX(raidPtr->recon_done_proc_mutex);
-       for (p = raidPtr->recon_done_procs; p; p = p->next) {
-               p->proc(raidPtr, p->arg);
-       }
-       RF_UNLOCK_MUTEX(raidPtr->recon_done_proc_mutex);
-}
-
 /**************************************************************************
  *
  * sets up the parameters that will be used by the reconstruction process
@@ -783,7 +771,6 @@
 
        }
 
-       SignalReconDone(raidPtr);
        return (0);
 }
 /*****************************************************************************