[src/trunk]: src/sys/fs/msdosfs PR/31312: Juan RP: Don't use negative cachein...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/82f1540efd49
branches:  trunk
changeset: 584368:82f1540efd49
user:      christos <christos%NetBSD.org@localhost>
date:      Wed Sep 14 15:07:22 2005 +0000

description:
PR/31312: Juan RP: Don't use negative cacheing on msdosfs, because of the
evil case preserving and case sensitive semantics. From FreeBSD.

diffstat:

 sys/fs/msdosfs/msdosfs_lookup.c |  11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diffs (37 lines):

diff -r 056ecaed7354 -r 82f1540efd49 sys/fs/msdosfs/msdosfs_lookup.c
--- a/sys/fs/msdosfs/msdosfs_lookup.c   Wed Sep 14 15:03:50 2005 +0000
+++ b/sys/fs/msdosfs/msdosfs_lookup.c   Wed Sep 14 15:07:22 2005 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: msdosfs_lookup.c,v 1.5 2005/05/29 21:00:29 christos Exp $      */
+/*     $NetBSD: msdosfs_lookup.c,v 1.6 2005/09/14 15:07:22 christos Exp $      */
 
 /*-
  * Copyright (C) 1994, 1995, 1997 Wolfgang Solfrank.
@@ -48,7 +48,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: msdosfs_lookup.c,v 1.5 2005/05/29 21:00:29 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: msdosfs_lookup.c,v 1.6 2005/09/14 15:07:22 christos Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -397,11 +397,18 @@
                return (EJUSTRETURN);
        }
 
+#if 0
        /*
         * Insert name into cache (as non-existent) if appropriate.
+        *
+        * XXX Negative caching is broken for msdosfs because the name
+        * cache doesn't understand peculiarities such as case insensitivity
+        * and 8.3 filenames.  Hence, it may not invalidate all negative
+        * entries if a file with this name is later created.
         */
        if ((cnp->cn_flags & MAKEENTRY) && nameiop != CREATE)
                cache_enter(vdp, *vpp, cnp);
+#endif
 
        return (ENOENT);