Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-2-0]: src/sys/netinet6 Pull up following revision(s) (requested b...



details:   https://anonhg.NetBSD.org/src/rev/83a0c7e646eb
branches:  netbsd-2-0
changeset: 565072:83a0c7e646eb
user:      bouyer <bouyer%NetBSD.org@localhost>
date:      Sat Dec 01 17:29:55 2007 +0000

description:
Pull up following revision(s) (requested by jdc in ticket #11393):
        sys/netinet6/ipcomp_input.c: revision 1.28
>From FreeBSD:
    In ipcomp6_input(), check 'md' not 'm' after a call to m_pulldown(): 'm'
    may be a stale pointer at this point, and we're interested in whether or
    not m_pulldown() failed.
    Noticed by:     Coverity Prevent analysis tool

diffstat:

 sys/netinet6/ipcomp_input.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r c5dc8cbd1a5f -r 83a0c7e646eb sys/netinet6/ipcomp_input.c
--- a/sys/netinet6/ipcomp_input.c       Mon Nov 19 20:34:08 2007 +0000
+++ b/sys/netinet6/ipcomp_input.c       Sat Dec 01 17:29:55 2007 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ipcomp_input.c,v 1.22 2004/02/11 10:47:29 itojun Exp $ */
+/*     $NetBSD: ipcomp_input.c,v 1.22.2.1 2007/12/01 17:29:55 bouyer Exp $     */
 /*     $KAME: ipcomp_input.c,v 1.29 2001/09/04 08:43:19 itojun Exp $   */
 
 /*
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ipcomp_input.c,v 1.22 2004/02/11 10:47:29 itojun Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ipcomp_input.c,v 1.22.2.1 2007/12/01 17:29:55 bouyer Exp $");
 
 #include "opt_inet.h"
 
@@ -265,7 +265,7 @@
        off = *offp;
 
        md = m_pulldown(m, off, sizeof(*ipcomp), NULL);
-       if (!m) {
+       if (!md) {
                m = NULL;       /* already freed */
                ipseclog((LOG_DEBUG, "IPv6 IPComp input: assumption failed "
                    "(pulldown failure)\n"));



Home | Main Index | Thread Index | Old Index