[src/trunk]: src/sys/ufs/lfs more XXX comment.

[yamt <yamt%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/56da14ab1595
branches:  trunk
changeset: 539838:56da14ab1595
user:      yamt <yamt%NetBSD.org@localhost>
date:      Wed Nov 27 11:36:40 2002 +0000

description:
more XXX comment.

diffstat:

 sys/ufs/lfs/lfs_bio.c |  17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)

diffs (38 lines):

diff -r 4b0f79d286f7 -r 56da14ab1595 sys/ufs/lfs/lfs_bio.c
--- a/sys/ufs/lfs/lfs_bio.c     Wed Nov 27 09:51:50 2002 +0000
+++ b/sys/ufs/lfs/lfs_bio.c     Wed Nov 27 11:36:40 2002 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: lfs_bio.c,v 1.46 2002/11/24 16:09:50 yamt Exp $        */
+/*     $NetBSD: lfs_bio.c,v 1.47 2002/11/27 11:36:40 yamt Exp $        */
 
 /*-
  * Copyright (c) 1999, 2000 The NetBSD Foundation, Inc.
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: lfs_bio.c,v 1.46 2002/11/24 16:09:50 yamt Exp $");
+__KERNEL_RCSID(0, "$NetBSD: lfs_bio.c,v 1.47 2002/11/27 11:36:40 yamt Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -115,10 +115,15 @@
  *
  * Called with vp locked.  (Note nowever that if fsb < 0, vp is ignored.)
  *
- * XXX YAMT
- * it isn't safe to unlock vp here
- * because we're passing data using inode from namei.
- * (eg. i_offset)
+ * XXX YAMT - it isn't safe to unlock vp here
+ * because the node might be modified while we sleep.
+ * (eg. cached states like i_offset might be stale,
+ *  the vnode might be truncated, etc..)
+ * maybe we should have a way to restart the vnode op. (EVOPRESTART?)
+ *
+ * XXX YAMT - we unlock the vnode so that cleaner can lock it.
+ * but it isn't enough. eg. for VOP_REMOVE, we should unlock the vnode that
+ * is going to be removed as well.
  */
 int
 lfs_reserve(struct lfs *fs, struct vnode *vp, int fsb)