Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic Remove work-around for Lite-On PNIC in tlp_filter...



details:   https://anonhg.NetBSD.org/src/rev/27cdf4055e41
branches:  trunk
changeset: 494226:27cdf4055e41
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Tue Jul 04 04:18:17 2000 +0000

description:
Remove work-around for Lite-On PNIC in tlp_filter_setup() that is
apparently no longer necessary (probably due to other fixes that
have happened in the filter setup path) and is in fact harmful.

Based on a patch from Krister Walfridsson, who claims this makes
his newer NetGear FA-310TX work (although, my older NetGear FA-310TX
still does not, but fails in an entirely different way).

diffstat:

 sys/dev/ic/tulip.c |  23 +++--------------------
 1 files changed, 3 insertions(+), 20 deletions(-)

diffs (37 lines):

diff -r 1a83009f9c62 -r 27cdf4055e41 sys/dev/ic/tulip.c
--- a/sys/dev/ic/tulip.c        Tue Jul 04 04:17:03 2000 +0000
+++ b/sys/dev/ic/tulip.c        Tue Jul 04 04:18:17 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: tulip.c,v 1.69 2000/06/28 17:13:05 mrg Exp $   */
+/*     $NetBSD: tulip.c,v 1.70 2000/07/04 04:18:17 thorpej Exp $       */
 
 /*-
  * Copyright (c) 1998, 1999, 2000 The NetBSD Foundation, Inc.
@@ -2555,25 +2555,8 @@
         * writing OPMODE will start the transmit and receive processes
         * in motion.
         */
-       if (ifp->if_flags & IFF_RUNNING) {
-               /*
-                * Actually, some chips seem to need a really hard
-                * kick in the head for this to work.  The genuine
-                * DEC chips can just be idled, but some of the
-                * clones seem to REALLY want a reset here.  Doing
-                * the reset will end up here again, but with
-                * IFF_RUNNING cleared.
-                */
-               switch (sc->sc_chip) {
-               case TULIP_CHIP_82C168:
-               case TULIP_CHIP_82C169:
-                       tlp_init(sc);
-                       return;
-
-               default:
-                       tlp_idle(sc, OPMODE_ST|OPMODE_SR);
-               }
-       }
+       if (ifp->if_flags & IFF_RUNNING)
+               tlp_idle(sc, OPMODE_ST|OPMODE_SR);
 
        sc->sc_opmode &= ~(OPMODE_PR|OPMODE_PM);
 



Home | Main Index | Thread Index | Old Index