Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic Apparently can't really look at excessive colliti...



details:   https://anonhg.NetBSD.org/src/rev/b62df938e4ec
branches:  trunk
changeset: 476367:b62df938e4ec
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Tue Sep 14 23:23:32 1999 +0000

description:
Apparently can't really look at excessive collitions and late collisions
in completed transmit descriptors.  These seem to be set even on successful
packet transmissions on my AlphaStation 500's 21040.

diffstat:

 sys/dev/ic/tulip.c |  12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diffs (31 lines):

diff -r deff5e8b05ab -r b62df938e4ec sys/dev/ic/tulip.c
--- a/sys/dev/ic/tulip.c        Tue Sep 14 22:49:14 1999 +0000
+++ b/sys/dev/ic/tulip.c        Tue Sep 14 23:23:32 1999 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: tulip.c,v 1.9 1999/09/14 22:25:50 thorpej Exp $        */
+/*     $NetBSD: tulip.c,v 1.10 1999/09/14 23:23:32 thorpej Exp $       */
 
 /*-
  * Copyright (c) 1998, 1999 The NetBSD Foundation, Inc.
@@ -1205,12 +1205,20 @@
                /*
                 * Check for errors and collisions.
                 */
-               if (txstat & TDSTAT_ES) {
+               if (txstat &
+                   (TDSTAT_Tx_UF|TDSTAT_Tx_NC|TDSTAT_Tx_LO|TDSTAT_Tx_TO)) {
                        ifp->if_oerrors++;
+#if 0
+                       /*
+                        * XXX Can't check for late or excessive collisions;
+                        * XXX Some 21040s seem to register those even on
+                        * XXX successful transmissions!
+                        */
                        if (txstat & TDSTAT_Tx_EC)
                                ifp->if_collisions += 16;
                        if (txstat & TDSTAT_Tx_LC)
                                ifp->if_collisions++;
+#endif
                } else {
                        /* Packet was transmitted successfully. */
                        ifp->if_opackets++;



Home | Main Index | Thread Index | Old Index