Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/dmover Fix another used-before-initialized bug that ...



details:   https://anonhg.NetBSD.org/src/rev/f4ec75261482
branches:  trunk
changeset: 555050:f4ec75261482
user:      briggs <briggs%NetBSD.org@localhost>
date:      Fri Nov 07 22:04:13 2003 +0000

description:
Fix another used-before-initialized bug that gcc uncovered.

diffstat:

 sys/dev/dmover/swdmover.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (34 lines):

diff -r 0deb3c411f2b -r f4ec75261482 sys/dev/dmover/swdmover.c
--- a/sys/dev/dmover/swdmover.c Fri Nov 07 21:27:56 2003 +0000
+++ b/sys/dev/dmover/swdmover.c Fri Nov 07 22:04:13 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: swdmover.c,v 1.6 2003/07/25 13:59:09 briggs Exp $      */
+/*     $NetBSD: swdmover.c,v 1.7 2003/11/07 22:04:13 briggs Exp $      */
 
 /*
  * Copyright (c) 2002, 2003 Wasabi Systems, Inc.
@@ -49,7 +49,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: swdmover.c,v 1.6 2003/07/25 13:59:09 briggs Exp $");
+__KERNEL_RCSID(0, "$NetBSD: swdmover.c,v 1.7 2003/11/07 22:04:13 briggs Exp $");
 
 #include <sys/param.h>
 #include <sys/lock.h>
@@ -291,6 +291,7 @@
                aligned = 1;
                if ((ulong) OUTBUF_L.l_addr & 0x3)
                        aligned = 0;
+               len = OUTBUF_L.l_len;
                for (i = 0 ; i < ninputs ; i++) {
                        if (len != INBUF_L(i).l_len) {
                                /* XXXLOCK */
@@ -302,7 +303,6 @@
                        if ((ulong) INBUF_L(i).l_addr & 0x3)
                                aligned = 0;
                }
-               len = OUTBUF_L.l_len;
                if (aligned) {
                        dst32 = (uint32_t *) OUTBUF_L.l_addr;
                        nwords = len / 4;



Home | Main Index | Thread Index | Old Index