Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern In fdatasync, do not call bioops.io_fsync, since we...



details:   https://anonhg.NetBSD.org/src/rev/5c2f78c748fe
branches:  trunk
changeset: 483677:5c2f78c748fe
user:      fvdl <fvdl%NetBSD.org@localhost>
date:      Wed Mar 15 16:30:39 2000 +0000

description:
In fdatasync, do not call bioops.io_fsync, since we're not flushing
metadata. If you do call it, there's actually a fair chance that it
will panic because its metadata dependencies were not cleared in
the VOP_FSYNC above (with FSYNC_DATAONLY).

diffstat:

 sys/kern/vfs_syscalls.c |  4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diffs (18 lines):

diff -r 94d9452689ac -r 5c2f78c748fe sys/kern/vfs_syscalls.c
--- a/sys/kern/vfs_syscalls.c   Wed Mar 15 16:28:45 2000 +0000
+++ b/sys/kern/vfs_syscalls.c   Wed Mar 15 16:30:39 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: vfs_syscalls.c,v 1.151 2000/03/03 05:21:04 mycroft Exp $       */
+/*     $NetBSD: vfs_syscalls.c,v 1.152 2000/03/15 16:30:39 fvdl Exp $  */
 
 /*
  * Copyright (c) 1989, 1993
@@ -2712,8 +2712,6 @@
        vp = (struct vnode *)fp->f_data;
        vn_lock(vp, LK_EXCLUSIVE | LK_RETRY);
        error = VOP_FSYNC(vp, fp->f_cred, FSYNC_WAIT|FSYNC_DATAONLY, p);
-       if (error == 0 && bioops.io_fsync != NULL)
-               (*bioops.io_fsync)(vp);
        VOP_UNLOCK(vp, 0);
        FILE_UNUSE(fp, p);
        return (error);



Home | Main Index | Thread Index | Old Index