Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/libc/arch/i386/sys I have no idea why this syscall wrapp...



details:   https://anonhg.NetBSD.org/src/rev/707f72ccc080
branches:  trunk
changeset: 509532:707f72ccc080
user:      ross <ross%NetBSD.org@localhost>
date:      Sun May 06 19:27:07 2001 +0000

description:
I have no idea why this syscall wrapper does some very un-unix-like
argument prefrobbing, in particular, it computes max(addr, __minbrk)
and uses that. The code is like this even in the ancient libc/i386 tree,
back to the earliest rev 1.2. I did not see it Lite 1, but I'm not totally
sure what the random site I found was serving up.
*
* However, I do know that it should use jb and not jl.
*

diffstat:

 lib/libc/arch/i386/sys/brk.S |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (36 lines):

diff -r 98dd2ead9aa3 -r 707f72ccc080 lib/libc/arch/i386/sys/brk.S
--- a/lib/libc/arch/i386/sys/brk.S      Sun May 06 19:22:32 2001 +0000
+++ b/lib/libc/arch/i386/sys/brk.S      Sun May 06 19:27:07 2001 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: brk.S,v 1.17 2000/12/08 22:57:57 mycroft Exp $ */
+/*     $NetBSD: brk.S,v 1.18 2001/05/06 19:27:07 ross Exp $    */
 
 /*-
  * Copyright (c) 1990 The Regents of the University of California.
@@ -40,7 +40,7 @@
 
 #include <machine/asm.h>
 #if defined(SYSLIBC_SCCS) && !defined(lint)
-       RCSID("$NetBSD: brk.S,v 1.17 2000/12/08 22:57:57 mycroft Exp $")
+       RCSID("$NetBSD: brk.S,v 1.18 2001/05/06 19:27:07 ross Exp $")
 #endif /* SYSLIBC_SCCS and not lint */
 
 #include "SYS.h"
@@ -65,7 +65,7 @@
        movl    PIC_GOT(_C_LABEL(__minbrk)),%edx
        PIC_EPILOGUE
        cmpl    %ecx,(%edx)
-       jl      1f
+       jb      1f
        movl    (%edx),%ecx
        movl    %ecx,4(%esp)
 1:
@@ -85,7 +85,7 @@
 #else
        movl    4(%esp),%ecx
        cmpl    %ecx,_C_LABEL(__minbrk)
-       jl      1f
+       jb      1f
        movl    _C_LABEL(__minbrk),%ecx
        movl    %ecx,4(%esp)
 1:



Home | Main Index | Thread Index | Old Index