Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb PQUIRK_NODOORLOCK seems to be strictly unnecessa...



details:   https://anonhg.NetBSD.org/src/rev/fc987df5f431
branches:  trunk
changeset: 551617:fc987df5f431
user:      mycroft <mycroft%NetBSD.org@localhost>
date:      Tue Sep 09 01:35:47 2003 +0000

description:
PQUIRK_NODOORLOCK seems to be strictly unnecessary.  If the drive doesn't
support it, we'll just get an ILLEGAL REQUEST and ignore it.  Furthermore,
on the PQI Travel Flash at least, it works just fine without.  These seem to
have been added in omnibus changes for particular devices, along with other
"quirks" that are now gone.  Adios, we won't cry for you.

diffstat:

 sys/dev/usb/umass_quirks.c |  36 ++----------------------------------
 1 files changed, 2 insertions(+), 34 deletions(-)

diffs (64 lines):

diff -r dbfbb2d790db -r fc987df5f431 sys/dev/usb/umass_quirks.c
--- a/sys/dev/usb/umass_quirks.c        Tue Sep 09 00:22:17 2003 +0000
+++ b/sys/dev/usb/umass_quirks.c        Tue Sep 09 01:35:47 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: umass_quirks.c,v 1.50 2003/09/08 19:57:33 mycroft Exp $        */
+/*     $NetBSD: umass_quirks.c,v 1.51 2003/09/09 01:35:47 mycroft Exp $        */
 
 /*
  * Copyright (c) 2001 The NetBSD Foundation, Inc.
@@ -37,7 +37,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: umass_quirks.c,v 1.50 2003/09/08 19:57:33 mycroft Exp $");
+__KERNEL_RCSID(0, "$NetBSD: umass_quirks.c,v 1.51 2003/09/09 01:35:47 mycroft Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -102,22 +102,6 @@
          NULL, NULL
        },
 
-       { { USB_VENDOR_MSYSTEMS, USB_PRODUCT_MSYSTEMS_DISKONKEY },
-         UMASS_WPROTO_UNSPEC, UMASS_CPROTO_UNSPEC,
-         0,
-         PQUIRK_NODOORLOCK,
-         UMATCH_DEVCLASS_DEVSUBCLASS_DEVPROTO,
-         NULL, NULL
-       },
-
-       { { USB_VENDOR_MSYSTEMS, USB_PRODUCT_MSYSTEMS_DISKONKEY2 },
-         UMASS_WPROTO_UNSPEC, UMASS_CPROTO_UNSPEC,
-         0,
-         PQUIRK_NODOORLOCK,
-         UMATCH_DEVCLASS_DEVSUBCLASS_DEVPROTO,
-         NULL, NULL
-       },
-
        { { USB_VENDOR_OLYMPUS, USB_PRODUCT_OLYMPUS_C1 },
          UMASS_WPROTO_UNSPEC, UMASS_CPROTO_UNSPEC,
          UMASS_QUIRK_WRONG_CSWSIG,
@@ -126,22 +110,6 @@
          NULL, NULL
        },
 
-       { { USB_VENDOR_PEN, USB_PRODUCT_PEN_MOBILEDRIVE },
-         UMASS_WPROTO_UNSPEC, UMASS_CPROTO_UNSPEC,
-         0,
-         PQUIRK_NODOORLOCK,
-         UMATCH_DEVCLASS_DEVSUBCLASS_DEVPROTO,
-         NULL, NULL
-       },
-
-       { { USB_VENDOR_PQI, USB_PRODUCT_PQI_TRAVELFLASH },
-         UMASS_WPROTO_UNSPEC, UMASS_CPROTO_UNSPEC,
-         0,
-         PQUIRK_NODOORLOCK,
-         UMATCH_VENDOR_PRODUCT,
-         NULL, NULL
-       },
-
        { { USB_VENDOR_SCANLOGIC, USB_PRODUCT_SCANLOGIC_SL11R },
          UMASS_WPROTO_UNSPEC, UMASS_CPROTO_UFI,
          UMASS_QUIRK_WRONG_CSWTAG,



Home | Main Index | Thread Index | Old Index