Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci Return an error when a read operation fails, ins...



details:   https://anonhg.NetBSD.org/src/rev/d1f0e6a55d81
branches:  trunk
changeset: 571073:d1f0e6a55d81
user:      cube <cube%NetBSD.org@localhost>
date:      Wed Nov 10 17:17:14 2004 +0000

description:
Return an error when a read operation fails, instead of pretending it
succeeded and transmitting a bogus value.

diffstat:

 sys/dev/pci/auich.c |  7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diffs (28 lines):

diff -r 89720f85357d -r d1f0e6a55d81 sys/dev/pci/auich.c
--- a/sys/dev/pci/auich.c       Wed Nov 10 17:00:41 2004 +0000
+++ b/sys/dev/pci/auich.c       Wed Nov 10 17:17:14 2004 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: auich.c,v 1.76 2004/11/10 14:14:09 cube Exp $  */
+/*     $NetBSD: auich.c,v 1.77 2004/11/10 17:17:14 cube Exp $  */
 
 /*-
  * Copyright (c) 2000, 2004 The NetBSD Foundation, Inc.
@@ -118,7 +118,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: auich.c,v 1.76 2004/11/10 14:14:09 cube Exp $");
+__KERNEL_RCSID(0, "$NetBSD: auich.c,v 1.77 2004/11/10 17:17:14 cube Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -624,6 +624,9 @@
                        bus_space_write_4(sc->iot, sc->aud_ioh, ICH_GSTS,
                                          status & ~(ICH_SRI|ICH_PRI|ICH_GSCI));
                        *val = 0xffff;
+                       DPRINTF(ICH_DEBUG_CODECIO,
+                           ("%s: read_codec error\n", sc->sc_dev.dv_xname));
+                       return -1;
                }
                return 0;
        } else {



Home | Main Index | Thread Index | Old Index