Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/eisa Don't do EISA reset on attach. This made the ca...



details:   https://anonhg.NetBSD.org/src/rev/09088cfa9d54
branches:  trunk
changeset: 542823:09088cfa9d54
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Sat Feb 08 12:06:13 2003 +0000

description:
Don't do EISA reset on attach. This made the card reset to use default irq, rather
than to use the one configured by EISA, and perhaps had some other side
effects - according to Pavel Cahyna, NOT doing the reset improved receive
performance significantly.
This also resolves old thread on current-users regarding this EISA card.

diffstat:

 sys/dev/eisa/if_ep_eisa.c |  11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diffs (33 lines):

diff -r 3bd95ca2bfcc -r 09088cfa9d54 sys/dev/eisa/if_ep_eisa.c
--- a/sys/dev/eisa/if_ep_eisa.c Sat Feb 08 12:00:36 2003 +0000
+++ b/sys/dev/eisa/if_ep_eisa.c Sat Feb 08 12:06:13 2003 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_ep_eisa.c,v 1.27 2002/10/02 16:33:47 thorpej Exp $  */
+/*     $NetBSD: if_ep_eisa.c,v 1.28 2003/02/08 12:06:13 jdolecek Exp $ */
 
 /*-
  * Copyright (c) 1998 The NetBSD Foundation, Inc.
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_ep_eisa.c,v 1.27 2002/10/02 16:33:47 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_ep_eisa.c,v 1.28 2003/02/08 12:06:13 jdolecek Exp $");
 
 #include "opt_inet.h"
 #include "opt_ns.h"
@@ -245,13 +245,8 @@
        sc->sc_ioh = ioh;
        sc->sc_iot = iot;
 
-       /* Reset card. */
-       bus_space_write_1(iot, ioh_cfg, EP_EISA_CFG_CONTROL, 
-           EISA_ENABLE | EISA_RESET);
+       bus_space_write_1(iot, ioh_cfg, EP_EISA_CFG_CONTROL, EISA_ENABLE);
        delay(4000);
-       bus_space_write_1(iot, ioh_cfg, EP_EISA_CFG_CONTROL, EISA_ENABLE);
-       /* Wait for reset? */
-       delay(1000);
 
        /* Read the IRQ from the card. */
        irq = bus_space_read_2(iot, ioh_cfg, EP_EISA_CFG_RESOURCE) >> 12;



Home | Main Index | Thread Index | Old Index