[src/trunk]: src/sys change the lf_advlock() arguments from

[jdolecek <jdolecek%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/8fffb34fe790
branches:  trunk
changeset: 495127:8fffb34fe790
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Sat Jul 22 15:26:11 2000 +0000

description:
change the lf_advlock() arguments from

int     lf_advlock __P((struct lockf **,
           off_t, caddr_t, int, struct flock *, int));
to

int     lf_advlock __P((struct vop_advlock_args *, struct lockf **, off_t));

This matches common usage and is also compatible with similar change
in FreeBSD (though they use u_quad_t as last arg).

diffstat:

 sys/kern/vfs_lockf.c           |  18 ++++++++----------
 sys/miscfs/specfs/spec_vnops.c |   5 ++---
 sys/msdosfs/msdosfs_vnops.c    |   5 ++---
 sys/nfs/nfs_vnops.c            |   5 ++---
 sys/sys/lockf.h                |   5 ++---
 sys/ufs/ext2fs/ext2fs_vnops.c  |   5 ++---
 sys/ufs/ufs/ufs_vnops.c        |   5 ++---
 7 files changed, 20 insertions(+), 28 deletions(-)

diffs (168 lines):

diff -r 75b146e0a339 -r 8fffb34fe790 sys/kern/vfs_lockf.c
--- a/sys/kern/vfs_lockf.c      Sat Jul 22 15:05:47 2000 +0000
+++ b/sys/kern/vfs_lockf.c      Sat Jul 22 15:26:11 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: vfs_lockf.c,v 1.16 2000/06/12 14:33:06 sommerfeld Exp $        */
+/*     $NetBSD: vfs_lockf.c,v 1.17 2000/07/22 15:26:13 jdolecek Exp $  */
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1993
@@ -86,14 +86,12 @@
  * Do an advisory lock operation.
  */
 int
-lf_advlock(head, size, id, op, fl, flags)
+lf_advlock(ap, head, size)
+       struct vop_advlock_args *ap;
        struct lockf **head;
        off_t size;
-       caddr_t id;
-       int op;
-       struct flock *fl;
-       int flags;
 {
+       struct flock *fl = ap->a_fl;
        struct lockf *lock;
        off_t start, end;
        int error;
@@ -125,7 +123,7 @@
         * Avoid the common case of unlocking when inode has no locks.
         */
        if (*head == (struct lockf *)0) {
-               if (op != F_SETLK) {
+               if (ap->a_op != F_SETLK) {
                        fl->l_type = F_UNLCK;
                        return (0);
                }
@@ -141,16 +139,16 @@
        MALLOC(lock, struct lockf *, sizeof(*lock), M_LOCKF, M_WAITOK);
        lock->lf_start = start;
        lock->lf_end = end;
-       lock->lf_id = id;
+       lock->lf_id = ap->a_id;
        lock->lf_head = head;
        lock->lf_type = fl->l_type;
        lock->lf_next = (struct lockf *)0;
        TAILQ_INIT(&lock->lf_blkhd);
-       lock->lf_flags = flags;
+       lock->lf_flags = ap->a_flags;
        /*
         * Do the requested operation.
         */
-       switch (op) {
+       switch (ap->a_op) {
 
        case F_SETLK:
                return (lf_setlock(lock));
diff -r 75b146e0a339 -r 8fffb34fe790 sys/miscfs/specfs/spec_vnops.c
--- a/sys/miscfs/specfs/spec_vnops.c    Sat Jul 22 15:05:47 2000 +0000
+++ b/sys/miscfs/specfs/spec_vnops.c    Sat Jul 22 15:26:11 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: spec_vnops.c,v 1.48 2000/03/30 12:22:14 augustss Exp $ */
+/*     $NetBSD: spec_vnops.c,v 1.49 2000/07/22 15:26:14 jdolecek Exp $ */
 
 /*
  * Copyright (c) 1989, 1993
@@ -730,6 +730,5 @@
        } */ *ap = v;
        struct vnode *vp = ap->a_vp;
 
-       return (lf_advlock(&vp->v_speclockf, (off_t)0, ap->a_id, ap->a_op,
-                          ap->a_fl, ap->a_flags));
+       return lf_advlock(ap, &vp->v_speclockf, (off_t)0);
 }
diff -r 75b146e0a339 -r 8fffb34fe790 sys/msdosfs/msdosfs_vnops.c
--- a/sys/msdosfs/msdosfs_vnops.c       Sat Jul 22 15:05:47 2000 +0000
+++ b/sys/msdosfs/msdosfs_vnops.c       Sat Jul 22 15:26:11 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: msdosfs_vnops.c,v 1.98 2000/06/28 02:49:15 mrg Exp $   */
+/*     $NetBSD: msdosfs_vnops.c,v 1.99 2000/07/22 15:26:12 jdolecek Exp $      */
 
 /*-
  * Copyright (C) 1994, 1995, 1997 Wolfgang Solfrank.
@@ -1847,8 +1847,7 @@
        } */ *ap = v;
        struct denode *dep = VTODE(ap->a_vp);
 
-       return (lf_advlock(&dep->de_lockf, dep->de_FileSize, ap->a_id, ap->a_op,
-           ap->a_fl, ap->a_flags));
+       return lf_advlock(ap, &dep->de_lockf, dep->de_FileSize);
 }
 
 int
diff -r 75b146e0a339 -r 8fffb34fe790 sys/nfs/nfs_vnops.c
--- a/sys/nfs/nfs_vnops.c       Sat Jul 22 15:05:47 2000 +0000
+++ b/sys/nfs/nfs_vnops.c       Sat Jul 22 15:26:11 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nfs_vnops.c,v 1.114 2000/06/27 17:52:36 mrg Exp $      */
+/*     $NetBSD: nfs_vnops.c,v 1.115 2000/07/22 15:26:14 jdolecek Exp $ */
 
 /*
  * Copyright (c) 1989, 1993
@@ -3049,8 +3049,7 @@
        } */ *ap = v;
        struct nfsnode *np = VTONFS(ap->a_vp);
 
-       return (lf_advlock(&np->n_lockf, np->n_size, ap->a_id, ap->a_op,
-           ap->a_fl, ap->a_flags));
+       return lf_advlock(ap, &np->n_lockf, np->n_size);
 }
 
 /*
diff -r 75b146e0a339 -r 8fffb34fe790 sys/sys/lockf.h
--- a/sys/sys/lockf.h   Sat Jul 22 15:05:47 2000 +0000
+++ b/sys/sys/lockf.h   Sat Jul 22 15:26:11 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: lockf.h,v 1.8 2000/06/12 14:33:04 sommerfeld Exp $     */
+/*     $NetBSD: lockf.h,v 1.9 2000/07/22 15:26:11 jdolecek Exp $       */
 
 /*
  * Copyright (c) 1991, 1993
@@ -73,8 +73,7 @@
 
 __BEGIN_DECLS
 void    lf_addblock __P((struct lockf *, struct lockf *));
-int     lf_advlock __P((struct lockf **,
-           off_t, caddr_t, int, struct flock *, int));
+int     lf_advlock __P((struct vop_advlock_args *, struct lockf **, off_t));
 int     lf_clearlock __P((struct lockf *));
 int     lf_findoverlap __P((struct lockf *,
            struct lockf *, int, struct lockf ***, struct lockf **));
diff -r 75b146e0a339 -r 8fffb34fe790 sys/ufs/ext2fs/ext2fs_vnops.c
--- a/sys/ufs/ext2fs/ext2fs_vnops.c     Sat Jul 22 15:05:47 2000 +0000
+++ b/sys/ufs/ext2fs/ext2fs_vnops.c     Sat Jul 22 15:26:11 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ext2fs_vnops.c,v 1.27 2000/06/28 14:16:38 mrg Exp $    */
+/*     $NetBSD: ext2fs_vnops.c,v 1.28 2000/07/22 15:26:15 jdolecek Exp $       */
 
 /*
  * Copyright (c) 1997 Manuel Bouyer.
@@ -1253,8 +1253,7 @@
        } */ *ap = v;
        struct inode *ip = VTOI(ap->a_vp);
 
-       return (lf_advlock(&ip->i_lockf, ip->i_e2fs_size, ap->a_id, ap->a_op,
-           ap->a_fl, ap->a_flags));
+       return lf_advlock(ap, &ip->i_lockf, ip->i_e2fs_size);
 }
 
 /*
diff -r 75b146e0a339 -r 8fffb34fe790 sys/ufs/ufs/ufs_vnops.c
--- a/sys/ufs/ufs/ufs_vnops.c   Sat Jul 22 15:05:47 2000 +0000
+++ b/sys/ufs/ufs/ufs_vnops.c   Sat Jul 22 15:26:11 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ufs_vnops.c,v 1.71 2000/07/05 22:25:45 perseant Exp $  */
+/*     $NetBSD: ufs_vnops.c,v 1.72 2000/07/22 15:26:16 jdolecek Exp $  */
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1993, 1995
@@ -1884,8 +1884,7 @@
        } */ *ap = v;
        struct inode *ip = VTOI(ap->a_vp);
 
-       return (lf_advlock(&ip->i_lockf, ip->i_ffs_size, ap->a_id, ap->a_op,
-           ap->a_fl, ap->a_flags));
+       return lf_advlock(ap, &ip->i_lockf, ip->i_ffs_size);
 }
 
 /*