Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pcmcia No need to call wi_setmulti() if ether_{add, d...



details:   https://anonhg.NetBSD.org/src/rev/90e9251b0b58
branches:  trunk
changeset: 484160:90e9251b0b58
user:      enami <enami%NetBSD.org@localhost>
date:      Mon Mar 27 06:48:05 2000 +0000

description:
No need to call wi_setmulti() if ether_{add,del}multi returns 0.

diffstat:

 sys/dev/pcmcia/if_wi.c |  13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diffs (41 lines):

diff -r 003849e41c50 -r 90e9251b0b58 sys/dev/pcmcia/if_wi.c
--- a/sys/dev/pcmcia/if_wi.c    Mon Mar 27 06:41:02 2000 +0000
+++ b/sys/dev/pcmcia/if_wi.c    Mon Mar 27 06:48:05 2000 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_wi.c,v 1.14 2000/03/23 07:01:42 thorpej Exp $       */
+/*     $NetBSD: if_wi.c,v 1.15 2000/03/27 06:48:05 enami Exp $ */
 
 /*
  * Copyright (c) 1997, 1998, 1999
@@ -31,7 +31,7 @@
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  *
- *     $Id: if_wi.c,v 1.14 2000/03/23 07:01:42 thorpej Exp $
+ *     $Id: if_wi.c,v 1.15 2000/03/27 06:48:05 enami Exp $
  */
 
 /*
@@ -117,7 +117,7 @@
 
 #if !defined(lint)
 static const char rcsid[] =
-       "$Id: if_wi.c,v 1.14 2000/03/23 07:01:42 thorpej Exp $";
+       "$Id: if_wi.c,v 1.15 2000/03/27 06:48:05 enami Exp $";
 #endif
 
 #ifdef foo
@@ -1193,8 +1193,11 @@
                error = (command == SIOCADDMULTI) ?
                    ether_addmulti(ifr, &sc->sc_ethercom) :
                    ether_delmulti(ifr, &sc->sc_ethercom);
-               if (error == ENETRESET || error == 0) {
-                       /* Configure list onto the chip. */
+               if (error == ENETRESET) {
+                       /*
+                        * Multicast list has changed; set the hardware filter
+                        * accordingly.
+                        */
                        wi_setmulti(sc);
                        error = 0;
                }



Home | Main Index | Thread Index | Old Index