[src/trunk]: src/sys/dev/hdaudio Even though the spec says SRST should read b...

[jmcneill <jmcneill%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/03e4f9c670fa
branches:  trunk
changeset: 458008:03e4f9c670fa
user:      jmcneill <jmcneill%NetBSD.org@localhost>
date:      Fri Jul 26 11:13:46 2019 +0000

description:
Even though the spec says SRST should read back as 1 after being set, this
does not appear to be the case with QEMU when using single byte accesses.

Instead of printing an error and giving up, continue and try to leave
stream reset state even if setting SRST times out.

diffstat:

 sys/dev/hdaudio/hdaudio.c |  8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diffs (29 lines):

diff -r 058ed3a6d992 -r 03e4f9c670fa sys/dev/hdaudio/hdaudio.c
--- a/sys/dev/hdaudio/hdaudio.c Fri Jul 26 10:53:45 2019 +0000
+++ b/sys/dev/hdaudio/hdaudio.c Fri Jul 26 11:13:46 2019 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: hdaudio.c,v 1.8 2017/11/24 17:51:10 jmcneill Exp $ */
+/* $NetBSD: hdaudio.c,v 1.9 2019/07/26 11:13:46 jmcneill Exp $ */
 
 /*
  * Copyright (c) 2009 Precedence Technologies Ltd <support%precedence.co.uk@localhost>
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: hdaudio.c,v 1.8 2017/11/24 17:51:10 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: hdaudio.c,v 1.9 2019/07/26 11:13:46 jmcneill Exp $");
 
 #include <sys/types.h>
 #include <sys/param.h>
@@ -1172,10 +1172,6 @@
                        break;
                hda_delay(10);
        } while (--retry > 0);
-       if (retry == 0) {
-               hda_error(sc, "timeout entering stream reset state\n");
-               return;
-       }
 
        ctl0 &= ~HDAUDIO_CTL_SRST;
        hda_write1(sc, HDAUDIO_SD_CTL0(snum), ctl0);