[src/trunk]: src/share/mk Don't add -Wabi to CXXFLAGS for gcc 8. It warns ab...

[uwe <uwe%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/e56a49d55c01
branches:  trunk
changeset: 455050:e56a49d55c01
user:      uwe <uwe%NetBSD.org@localhost>
date:      Sat Oct 05 18:37:39 2019 +0000

description:
Don't add -Wabi to CXXFLAGS for gcc 8.  It warns about differences
from the most up-to-date ABI, which in gcc 8 is used by default.
XXX: This needs a better condition.

diffstat:

 share/mk/bsd.sys.mk |  6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diffs (21 lines):

diff -r 7a80331c9064 -r e56a49d55c01 share/mk/bsd.sys.mk
--- a/share/mk/bsd.sys.mk       Sat Oct 05 18:07:58 2019 +0000
+++ b/share/mk/bsd.sys.mk       Sat Oct 05 18:37:39 2019 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: bsd.sys.mk,v 1.292 2019/05/22 08:31:25 kamil Exp $
+#      $NetBSD: bsd.sys.mk,v 1.293 2019/10/05 18:37:39 uwe Exp $
 #
 # Build definitions used for NetBSD source tree builds.
 
@@ -103,7 +103,11 @@
 CFLAGS+=       -Wextra -Wno-unused-parameter
 # Readd -Wno-sign-compare to override -Wextra with clang
 CFLAGS+=       -Wno-sign-compare
+.if "${ACTIVE_CC}" == "gcc" && ${HAVE_GCC} != "8"
+#  XXX: Won't warn about anything.  -Wabi warns about differences from
+#  the most up-to-date ABI, which in g++ 8 is used by default.
 CXXFLAGS+=     -Wabi
+.endif
 CXXFLAGS+=     -Wold-style-cast
 CXXFLAGS+=     -Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder \
                -Wno-deprecated -Woverloaded-virtual -Wsign-promo -Wsynth