Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Add XXXs for SCTP bugs.



details:   https://anonhg.NetBSD.org/src/rev/4540e87a3a8d
branches:  trunk
changeset: 451740:4540e87a3a8d
user:      maxv <maxv%NetBSD.org@localhost>
date:      Sat Jun 01 15:20:51 2019 +0000

description:
Add XXXs for SCTP bugs.

diffstat:

 sys/kern/uipc_socket.c |  7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diffs (35 lines):

diff -r d4557b480dbd -r 4540e87a3a8d sys/kern/uipc_socket.c
--- a/sys/kern/uipc_socket.c    Sat Jun 01 15:18:42 2019 +0000
+++ b/sys/kern/uipc_socket.c    Sat Jun 01 15:20:51 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uipc_socket.c,v 1.279 2019/05/08 14:05:18 christos Exp $       */
+/*     $NetBSD: uipc_socket.c,v 1.280 2019/06/01 15:20:51 maxv Exp $   */
 
 /*
  * Copyright (c) 2002, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.279 2019/05/08 14:05:18 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.280 2019/06/01 15:20:51 maxv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_compat_netbsd.h"
@@ -1323,6 +1323,7 @@
                                m = m->m_next;
                        } else {
                                sbfree(&so->so_rcv, m);
+                               /* XXX XXX XXX: should set mbuf_removed? */
                                if (paddr) {
                                        *paddr = m;
                                        so->so_rcv.sb_mb = m->m_next;
@@ -1331,6 +1332,8 @@
                                } else {
                                        m = so->so_rcv.sb_mb = m_free(m);
                                }
+                               /* XXX XXX XXX: isn't there an sbsync()
+                                * missing here? */
                        }
                }
        }



Home | Main Index | Thread Index | Old Index