Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci fix a >15 year old code rework bug, and add a mi...



details:   https://anonhg.NetBSD.org/src/rev/3c22b15837a3
branches:  trunk
changeset: 448579:3c22b15837a3
user:      mrg <mrg%NetBSD.org@localhost>
date:      Tue Feb 05 11:20:21 2019 +0000

description:
fix a >15 year old code rework bug, and add a missing break;.

the code in rev 1.7 looks like it does in this change, but rev 1.8 would
write the I443 AGP_INTEL_AGPCTRL value, and then the other value.

diffstat:

 sys/dev/pci/agp_intel.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (26 lines):

diff -r 81d8990e11d0 -r 3c22b15837a3 sys/dev/pci/agp_intel.c
--- a/sys/dev/pci/agp_intel.c   Tue Feb 05 11:11:32 2019 +0000
+++ b/sys/dev/pci/agp_intel.c   Tue Feb 05 11:20:21 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: agp_intel.c,v 1.37 2011/04/04 20:37:56 dyoung Exp $    */
+/*     $NetBSD: agp_intel.c,v 1.38 2019/02/05 11:20:21 mrg Exp $       */
 
 /*-
  * Copyright (c) 2000 Doug Rabson
@@ -29,7 +29,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: agp_intel.c,v 1.37 2011/04/04 20:37:56 dyoung Exp $");
+__KERNEL_RCSID(0, "$NetBSD: agp_intel.c,v 1.38 2019/02/05 11:20:21 mrg Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -209,6 +209,7 @@
        case CHIP_I443:
                pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,
                    AGPCTRL_AGPRSE | AGPCTRL_GTLB);
+               break;
 
        default:
                pci_conf_write(sc->as_pc, sc->as_tag, AGP_INTEL_AGPCTRL,



Home | Main Index | Thread Index | Old Index