Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/nand add fallthru comments, and a comment this code ...



details:   https://anonhg.NetBSD.org/src/rev/b1bbd64e0f2b
branches:  trunk
changeset: 448559:b1bbd64e0f2b
user:      mrg <mrg%NetBSD.org@localhost>
date:      Tue Feb 05 08:02:19 2019 +0000

description:
add fallthru comments, and a comment this code needs attention

diffstat:

 sys/dev/nand/nandemulator.c |  8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diffs (32 lines):

diff -r fba8bfd1a191 -r b1bbd64e0f2b sys/dev/nand/nandemulator.c
--- a/sys/dev/nand/nandemulator.c       Tue Feb 05 07:47:15 2019 +0000
+++ b/sys/dev/nand/nandemulator.c       Tue Feb 05 08:02:19 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nandemulator.c,v 1.7 2015/08/20 14:40:18 christos Exp $        */
+/*     $NetBSD: nandemulator.c,v 1.8 2019/02/05 08:02:19 mrg Exp $     */
 
 /*-
  * Copyright (c) 2011 Department of Software Engineering,
@@ -32,7 +32,9 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nandemulator.c,v 1.7 2015/08/20 14:40:18 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nandemulator.c,v 1.8 2019/02/05 08:02:19 mrg Exp $");
+
+/* XXX this code likely needs work */
 
 #include <sys/param.h>
 #include <sys/device.h>
@@ -388,9 +390,11 @@
                break;
        case ONFI_PAGE_PROGRAM:
                sc->sc_register_writable = true;
+               /* FALLTHROUGH */
        case ONFI_READ:
        case ONFI_BLOCK_ERASE:
                sc->sc_address_counter = 0;
+               /* FALLTHROUGH */
        case ONFI_READ_ID:
        case ONFI_READ_PARAMETER_PAGE:
                sc->sc_io_len = 0;



Home | Main Index | Thread Index | Old Index