Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src Implement support for "pshared" POSIX semaphores.



details:   https://anonhg.NetBSD.org/src/rev/98f8542d38e3
branches:  trunk
changeset: 448434:98f8542d38e3
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Sun Feb 03 03:20:23 2019 +0000

description:
Implement support for "pshared" POSIX semaphores.

Fixes lib/53273 (and Firefox's multi-process tab feature).

diffstat:

 distrib/sets/lists/tests/mi        |    3 +-
 lib/libpthread/Makefile            |    3 +-
 lib/libpthread/sem.c               |  316 ------------------------------------
 lib/librt/sem.c                    |  162 ++++++++++++++----
 sys/compat/netbsd32/netbsd32_sem.c |   22 ++-
 sys/kern/uipc_sem.c                |  318 ++++++++++++++++++++++++++++++------
 sys/sys/ksem.h                     |   17 +-
 tests/kernel/Makefile              |    3 +-
 tests/kernel/t_ksem.c              |  145 ++++++++++++++++
 tests/lib/librt/t_sem.c            |  150 ++++++++++++++++-
 usr.bin/fstat/misc.c               |    5 +-
 11 files changed, 724 insertions(+), 420 deletions(-)

diffs (truncated from 1700 to 300 lines):

diff -r 2bd5d335c649 -r 98f8542d38e3 distrib/sets/lists/tests/mi
--- a/distrib/sets/lists/tests/mi       Sun Feb 03 03:19:25 2019 +0000
+++ b/distrib/sets/lists/tests/mi       Sun Feb 03 03:20:23 2019 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: mi,v 1.804 2019/01/25 18:33:58 christos Exp $
+# $NetBSD: mi,v 1.805 2019/02/03 03:20:23 thorpej Exp $
 #
 # Note: don't delete entries from here - mark them as "obsolete" instead.
 #
@@ -2180,6 +2180,7 @@
 ./usr/tests/kernel/t_filedesc                  tests-kernel-tests      atf,rump
 ./usr/tests/kernel/t_interp                    tests-kernel-tests      atf
 ./usr/tests/kernel/t_kauth_pr_47598            tests-kernel-tests      compattestfile,atf
+./usr/tests/kernel/t_ksem                      tests-kernel-tests      atf
 ./usr/tests/kernel/t_lock                      tests-kernel-tests      compattestfile,atf
 ./usr/tests/kernel/t_lockf                     tests-kernel-tests      compattestfile,atf
 ./usr/tests/kernel/t_lwpctl                    tests-obsolete          obsolete
diff -r 2bd5d335c649 -r 98f8542d38e3 lib/libpthread/Makefile
--- a/lib/libpthread/Makefile   Sun Feb 03 03:19:25 2019 +0000
+++ b/lib/libpthread/Makefile   Sun Feb 03 03:20:23 2019 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile,v 1.90 2018/06/09 23:45:56 christos Exp $
+#      $NetBSD: Makefile,v 1.91 2019/02/03 03:20:24 thorpej Exp $
 #
 
 NOSANITIZER=   # defined
@@ -66,6 +66,7 @@
 SRCS+= pthread_spin.c
 SRCS+= pthread_tsd.c
 SRCS+= res_state.c
+.PATH: ${.CURDIR}/../librt
 SRCS+= sem.c
 # Architecture-dependent files
 .if exists(${ARCHDIR}/pthread_md.S)
diff -r 2bd5d335c649 -r 98f8542d38e3 lib/libpthread/sem.c
--- a/lib/libpthread/sem.c      Sun Feb 03 03:19:25 2019 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,316 +0,0 @@
-/*     $NetBSD: sem.c,v 1.24 2012/03/10 18:01:10 joerg Exp $   */
-
-/*-
- * Copyright (c) 2003, 2006, 2007 The NetBSD Foundation, Inc.
- * All rights reserved.
- *
- * This code is derived from software contributed to The NetBSD Foundation
- * by Jason R. Thorpe of Wasabi Systems, Inc, and by Andrew Doran.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
- * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
- * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
- * POSSIBILITY OF SUCH DAMAGE.
- */
-
-/*
- * Copyright (C) 2000 Jason Evans <jasone%freebsd.org@localhost>.
- * All rights reserved.
- * 
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice(s), this list of conditions and the following disclaimer as
- *    the first lines of this file unmodified other than the possible
- *    addition of one or more copyright notices.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice(s), this list of conditions and the following disclaimer in
- *    the documentation and/or other materials provided with the
- *    distribution.
- * 
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER(S) ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE COPYRIGHT HOLDER(S) BE
- * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
- * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
- * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
- * OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
- * EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include <sys/cdefs.h>
-__RCSID("$NetBSD: sem.c,v 1.24 2012/03/10 18:01:10 joerg Exp $");
-
-#include <sys/types.h>
-#include <sys/ksem.h>
-#include <sys/queue.h>
-#include <stdlib.h>
-#include <errno.h>
-#include <fcntl.h>
-#include <semaphore.h>
-#include <stdarg.h>
-
-#include "pthread.h"
-
-struct _sem_st {
-       unsigned int    ksem_magic;
-#define        KSEM_MAGIC      0x90af0421U
-
-       LIST_ENTRY(_sem_st) ksem_list;
-       intptr_t                ksem_semid;     /* 0 -> user (non-shared) */
-       sem_t           *ksem_identity;
-};
-
-static int sem_alloc(unsigned int value, intptr_t semid, sem_t *semp);
-static void sem_free(sem_t sem);
-
-static LIST_HEAD(, _sem_st) named_sems = LIST_HEAD_INITIALIZER(&named_sems);
-static pthread_mutex_t named_sems_mtx = PTHREAD_MUTEX_INITIALIZER;
-
-static void
-sem_free(sem_t sem)
-{
-
-       sem->ksem_magic = 0;
-       free(sem);
-}
-
-static int
-sem_alloc(unsigned int value, intptr_t semid, sem_t *semp)
-{
-       sem_t sem;
-
-       if (value > SEM_VALUE_MAX)
-               return (EINVAL);
-
-       if ((sem = malloc(sizeof(struct _sem_st))) == NULL)
-               return (ENOSPC);
-
-       sem->ksem_magic = KSEM_MAGIC;
-       sem->ksem_semid = semid;
- 
-       *semp = sem;
-       return (0);
-}
-
-/* ARGSUSED */
-int
-sem_init(sem_t *sem, int pshared, unsigned int value)
-{
-       intptr_t        semid;
-       int error;
-
-       if (_ksem_init(value, &semid) == -1)
-               return (-1);
-
-       if ((error = sem_alloc(value, semid, sem)) != 0) {
-               _ksem_destroy(semid);
-               errno = error;
-               return (-1);
-       }
-
-       return (0);
-}
-
-int
-sem_destroy(sem_t *sem)
-{
-       int error, save_errno;
-
-#ifdef ERRORCHECK
-       if (sem == NULL || *sem == NULL || (*sem)->ksem_magic != KSEM_MAGIC) {
-               errno = EINVAL;
-               return (-1);
-       }
-#endif
-
-       error = _ksem_destroy((*sem)->ksem_semid);
-       save_errno = errno;
-       sem_free(*sem);
-       errno = save_errno;
-
-       return error;
-}
-
-sem_t *
-sem_open(const char *name, int oflag, ...)
-{
-       sem_t *sem, s;
-       intptr_t semid;
-       mode_t mode;
-       unsigned int value;
-       int error;
-       va_list ap;
-
-       mode = 0;
-       value = 0;
-
-       if (oflag & O_CREAT) {
-               va_start(ap, oflag);
-               mode = va_arg(ap, int);
-               value = va_arg(ap, unsigned int);
-               va_end(ap);
-       }
-
-       /*
-        * We can be lazy and let the kernel handle the oflag,
-        * we'll just merge duplicate IDs into our list.
-        */
-       if (_ksem_open(name, oflag, mode, value, &semid) == -1)
-               return (SEM_FAILED);
-
-       /*
-        * Search for a duplicate ID, we must return the same sem_t *
-        * if we locate one.
-        */
-       pthread_mutex_lock(&named_sems_mtx);
-       LIST_FOREACH(s, &named_sems, ksem_list) {
-               if (s->ksem_semid == semid) {
-                       pthread_mutex_unlock(&named_sems_mtx);
-                       return (s->ksem_identity);
-               }
-       }
-
-       if ((sem = malloc(sizeof(*sem))) == NULL) {
-               error = ENOSPC;
-               goto bad;
-       }
-       if ((error = sem_alloc(value, semid, sem)) != 0)
-               goto bad;
-
-       LIST_INSERT_HEAD(&named_sems, *sem, ksem_list);
-       pthread_mutex_unlock(&named_sems_mtx);
-       (*sem)->ksem_identity = sem;
-
-       return (sem);
-
- bad:
-       pthread_mutex_unlock(&named_sems_mtx);
-       _ksem_close(semid);
-       if (sem != NULL) {
-               if (*sem != NULL)
-                       sem_free(*sem);
-               free(sem);
-       }
-       errno = error;
-       return (SEM_FAILED);
-}
-
-int
-sem_close(sem_t *sem)
-{
-       int error, save_errno;
-
-#ifdef ERRORCHECK
-       if (sem == NULL || *sem == NULL || (*sem)->ksem_magic != KSEM_MAGIC) {
-               errno = EINVAL;
-               return (-1);
-       }
-#endif
-
-       pthread_mutex_lock(&named_sems_mtx);
-       error = _ksem_close((*sem)->ksem_semid);
-       LIST_REMOVE((*sem), ksem_list);
-       save_errno = errno;
-       pthread_mutex_unlock(&named_sems_mtx);
-       sem_free(*sem);
-       free(sem);
-       errno = save_errno;
-       return error;
-}
-
-int
-sem_unlink(const char *name)
-{
-
-       return (_ksem_unlink(name));
-}
-
-int
-sem_wait(sem_t *sem)
-{
-
-#ifdef ERRORCHECK
-       if (sem == NULL || *sem == NULL || (*sem)->ksem_magic != KSEM_MAGIC) {
-               errno = EINVAL;
-               return (-1);
-       }
-#endif
-
-       return (_ksem_wait((*sem)->ksem_semid));
-}
-



Home | Main Index | Thread Index | Old Index