[src/trunk]: src/sys/dev Add yet another PHY workaround. Disable generation o...

[msaitoh <msaitoh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/d9a738aff7c9
branches:  trunk
changeset: 448376:d9a738aff7c9
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Thu Jan 31 15:30:23 2019 +0000

description:
Add yet another PHY workaround. Disable generation of early preamble on 82577
PHY rev. 1 or 2 and 82578 PHY rev. 1.

diffstat:

 sys/dev/mii/inbmphyreg.h |  11 ++++++++++-
 sys/dev/pci/if_wm.c      |  43 +++++++++++++++++++++++++++++++++----------
 2 files changed, 43 insertions(+), 11 deletions(-)

diffs (107 lines):

diff -r 652974dfcde1 -r d9a738aff7c9 sys/dev/mii/inbmphyreg.h
--- a/sys/dev/mii/inbmphyreg.h  Thu Jan 31 15:27:57 2019 +0000
+++ b/sys/dev/mii/inbmphyreg.h  Thu Jan 31 15:30:23 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: inbmphyreg.h,v 1.17 2019/01/31 05:20:49 msaitoh Exp $  */
+/*     $NetBSD: inbmphyreg.h,v 1.18 2019/01/31 15:30:23 msaitoh Exp $  */
 /*******************************************************************************
 Copyright (c) 2001-2015, Intel Corporation 
 All rights reserved.
@@ -139,6 +139,15 @@
 #define        CV_SMB_CTRL             BME1000_REG(BM_PORT_CTRL_PAGE, 23)
 #define        CV_SMB_CTRL_FORCE_SMBUS __BIT(0)
 
+#define        BM_RATE_ADAPTATION_CTRL BME1000_REG(BM_PORT_CTRL_PAGE, 25)
+#define        BM_RATE_ADAPTATION_CTRL_RX_RXDV_PRE     __BIT(8)
+#define        BM_RATE_ADAPTATION_CTRL_RX_CRS_PRE      __BIT(7)
+
+/* KMRN FIFO Control and Status */
+#define HV_KMRN_FIFO_CTRLSTA                   BME1000_REG(770, 16)
+#define HV_KMRN_FIFO_CTRLSTA_PREAMBLE_MASK     0x7000
+#define HV_KMRN_FIFO_CTRLSTA_PREAMBLE_SHIFT    12
+
 #define        HV_PM_CTRL              BME1000_REG(770, 17)
 #define HV_PM_CTRL_K1_CLK_REQ  __BIT(9)
 #define        HV_PM_CTRL_K1_ENA       __BIT(14)
diff -r 652974dfcde1 -r d9a738aff7c9 sys/dev/pci/if_wm.c
--- a/sys/dev/pci/if_wm.c       Thu Jan 31 15:27:57 2019 +0000
+++ b/sys/dev/pci/if_wm.c       Thu Jan 31 15:30:23 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_wm.c,v 1.622 2019/01/31 05:48:32 msaitoh Exp $      */
+/*     $NetBSD: if_wm.c,v 1.623 2019/01/31 15:30:23 msaitoh Exp $      */
 
 /*
  * Copyright (c) 2001, 2002, 2003, 2004 Wasabi Systems, Inc.
@@ -83,7 +83,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.622 2019/01/31 05:48:32 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_wm.c,v 1.623 2019/01/31 15:30:23 msaitoh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_net_mpsafe.h"
@@ -15396,32 +15396,55 @@
 wm_hv_phy_workarounds_ich8lan(struct wm_softc *sc)
 {
        device_t dev = sc->sc_dev;
-       uint16_t phy_data;
+       struct mii_data *mii = &sc->sc_mii;
+       struct mii_softc *child;
+       uint16_t phy_data, phyrev = 0;
+       int phytype = sc->sc_phytype;
        int rv;
 
        DPRINTF(WM_DEBUG_INIT, ("%s: %s called\n",
                device_xname(dev), __func__));
        KASSERT(sc->sc_type == WM_T_PCH);
 
-       if (sc->sc_phytype == WMPHY_82577)
+       /* Set MDIO slow mode before any other MDIO access */
+       if (phytype == WMPHY_82577)
                if ((rv = wm_set_mdio_slow_mode_hv(sc)) != 0)
                        return rv;
 
-       /* XXX (PCH rev.2) && (82577 && (phy rev 2 or 3)) */
+       child = LIST_FIRST(&sc->sc_mii.mii_phys);
+       if (child != NULL)
+               phyrev = child->mii_mpd_rev;
 
        /* (82577 && (phy rev 1 or 2)) || (82578 & phy rev 1)*/
+       if ((child != NULL) &&
+           (((phytype == WMPHY_82577) && ((phyrev == 1) || (phyrev == 2))) ||
+               ((phytype == WMPHY_82578) && (phyrev == 1)))) {
+               /* Disable generation of early preamble (0x4431) */
+               rv = mii->mii_readreg(dev, 2, BM_RATE_ADAPTATION_CTRL,
+                   &phy_data);
+               if (rv != 0)
+                       return rv;
+               phy_data &= ~(BM_RATE_ADAPTATION_CTRL_RX_RXDV_PRE |
+                   BM_RATE_ADAPTATION_CTRL_RX_CRS_PRE);
+               rv = mii->mii_writereg(dev, 2, BM_RATE_ADAPTATION_CTRL,
+                   phy_data);
+               if (rv != 0)
+                       return rv;
+
+               /* Preamble tuning for SSC */
+               rv = mii->mii_writereg(dev, 2, HV_KMRN_FIFO_CTRLSTA, 0xa204);
+               if (rv != 0)
+                       return rv;
+       }
 
        /* 82578 */
-       if (sc->sc_phytype == WMPHY_82578) {
-               struct mii_softc *child;
-
+       if (phytype == WMPHY_82578) {
                /*
                 * Return registers to default by doing a soft reset then
                 * writing 0x3140 to the control register
                 * 0x3140 == BMCR_SPEED0 | BMCR_AUTOEN | BMCR_FDX | BMCR_SPEED1
                 */
-               child = LIST_FIRST(&sc->sc_mii.mii_phys);
-               if ((child != NULL) && (child->mii_mpd_rev < 2)) {
+               if ((child != NULL) && (phyrev < 2)) {
                        PHY_RESET(child);
                        rv = sc->sc_mii.mii_writereg(dev, 2, MII_BMCR,
                            0x3140);