Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys Improve my kern_time.c::rev1.192, systematically clear t...



details:   https://anonhg.NetBSD.org/src/rev/f04054421043
branches:  trunk
changeset: 446292:f04054421043
user:      maxv <maxv%NetBSD.org@localhost>
date:      Thu Nov 29 17:40:12 2018 +0000

description:
Improve my kern_time.c::rev1.192, systematically clear the buffers we get
from 'ptimer_pool' to prevent more leaks.

diffstat:

 sys/compat/linux/common/linux_misc_notalpha.c |  5 +++--
 sys/kern/kern_time.c                          |  5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diffs (52 lines):

diff -r df70f88f3234 -r f04054421043 sys/compat/linux/common/linux_misc_notalpha.c
--- a/sys/compat/linux/common/linux_misc_notalpha.c     Thu Nov 29 16:04:21 2018 +0000
+++ b/sys/compat/linux/common/linux_misc_notalpha.c     Thu Nov 29 17:40:12 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: linux_misc_notalpha.c,v 1.109 2014/11/09 17:48:08 maxv Exp $   */
+/*     $NetBSD: linux_misc_notalpha.c,v 1.110 2018/11/29 17:40:12 maxv Exp $   */
 
 /*-
  * Copyright (c) 1995, 1998, 2008 The NetBSD Foundation, Inc.
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: linux_misc_notalpha.c,v 1.109 2014/11/09 17:48:08 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: linux_misc_notalpha.c,v 1.110 2018/11/29 17:40:12 maxv Exp $");
 
 /*
  * Note that we must NOT include "opt_compat_linux32.h" here,
@@ -161,6 +161,7 @@
                if (spare == NULL) {
                        mutex_spin_exit(&timer_lock);
                        spare = pool_get(&ptimer_pool, PR_WAITOK);
+                       memset(spare, 0, sizeof(*spare));
                        goto retry;
                }
                ptp = spare;
diff -r df70f88f3234 -r f04054421043 sys/kern/kern_time.c
--- a/sys/kern/kern_time.c      Thu Nov 29 16:04:21 2018 +0000
+++ b/sys/kern/kern_time.c      Thu Nov 29 17:40:12 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: kern_time.c,v 1.192 2018/11/28 15:10:40 maxv Exp $     */
+/*     $NetBSD: kern_time.c,v 1.193 2018/11/29 17:40:12 maxv Exp $     */
 
 /*-
  * Copyright (c) 2000, 2004, 2005, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -61,7 +61,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_time.c,v 1.192 2018/11/28 15:10:40 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_time.c,v 1.193 2018/11/29 17:40:12 maxv Exp $");
 
 #include <sys/param.h>
 #include <sys/resourcevar.h>
@@ -1166,6 +1166,7 @@
                if (spare == NULL) {
                        mutex_spin_exit(&timer_lock);
                        spare = pool_get(&ptimer_pool, PR_WAITOK);
+                       memset(spare, 0, sizeof(*spare));
                        goto retry;
                }
                pt = spare;



Home | Main Index | Thread Index | Old Index