Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Fix info leak. There is one branch where 'status' i...



details:   https://anonhg.NetBSD.org/src/rev/c2903503e7a0
branches:  trunk
changeset: 446287:c2903503e7a0
user:      maxv <maxv%NetBSD.org@localhost>
date:      Thu Nov 29 12:37:22 2018 +0000

description:
Fix info leak. There is one branch where 'status' is not initialized at
all.

        + Possible info leak: [len=4, leaked=4]
        | #0 0xffffffff80baf397 in kleak_copyout
        | #1 0xffffffff80b56d0c in sys_wait6
        | #2 0xffffffff80259c42 in syscall

diffstat:

 sys/kern/kern_exit.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (26 lines):

diff -r edfa4987d1cf -r c2903503e7a0 sys/kern/kern_exit.c
--- a/sys/kern/kern_exit.c      Thu Nov 29 11:45:52 2018 +0000
+++ b/sys/kern/kern_exit.c      Thu Nov 29 12:37:22 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: kern_exit.c,v 1.272 2018/07/12 10:46:48 maxv Exp $     */
+/*     $NetBSD: kern_exit.c,v 1.273 2018/11/29 12:37:22 maxv Exp $     */
 
 /*-
  * Copyright (c) 1998, 1999, 2006, 2007, 2008 The NetBSD Foundation, Inc.
@@ -67,7 +67,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_exit.c,v 1.272 2018/07/12 10:46:48 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_exit.c,v 1.273 2018/11/29 12:37:22 maxv Exp $");
 
 #include "opt_ktrace.h"
 #include "opt_dtrace.h"
@@ -647,6 +647,7 @@
        if (child == NULL) {
                mutex_exit(proc_lock);
                *pid = 0;
+               *status = 0;
                return error;
        }
        *pid = child->p_pid;



Home | Main Index | Thread Index | Old Index