[src/trunk]: src/external/apache2/mDNSResponder/dist/mDNSPosix It is not an e...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/38e661362111
branches:  trunk
changeset: 445980:38e661362111
user:      christos <christos%NetBSD.org@localhost>
date:      Mon Nov 19 08:14:28 2018 +0000

description:
It is not an error if we did not find any IPv4 interfaces. It could
be the case we never have V4 interfaces (in a V6 system) so this
is bogus. The code was recently changed to ignore loopback interfaces.
If mdnsd was started too early, this means that no interfaces would
be found (since interfaces down, with no addresses, or tentative
are ignored). I put back the loopback interfaces yesterday to avoid
this error, but this seems like the left hand not knowing what the
right hand does because whoever removed the loopback interfaces
from the list, did not read the 'self discovery' comment and the
special code that deals with loopback in this file. Nevertheless,
I think it is better to ignore the loopback interfaces in the long
run, but it is ok to keep them around since the code is handling
them just fine (and works both with and without them).

diffstat:

 external/apache2/mDNSResponder/dist/mDNSPosix/mDNSPosix.c |  2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diffs (13 lines):

diff -r ff78a5cc698e -r 38e661362111 external/apache2/mDNSResponder/dist/mDNSPosix/mDNSPosix.c
--- a/external/apache2/mDNSResponder/dist/mDNSPosix/mDNSPosix.c Mon Nov 19 06:38:58 2018 +0000
+++ b/external/apache2/mDNSResponder/dist/mDNSPosix/mDNSPosix.c Mon Nov 19 08:14:28 2018 +0000
@@ -977,7 +977,9 @@
     assert(m != NULL);
     debugf("SetupInterfaceList");
 
+#if 0
     if (intfList == NULL) err = ENOENT;
+#endif
 
 #if HAVE_IPV6
     if (err == 0)       /* Link the IPv6 list to the end of the IPv4 list */