Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev move mvsata(4) related items from ata/TODO.ncq to de...



details:   https://anonhg.NetBSD.org/src/rev/aed7c5368870
branches:  trunk
changeset: 445317:aed7c5368870
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Mon Oct 22 20:30:52 2018 +0000

description:
move mvsata(4) related items from ata/TODO.ncq to dev/ic/mvsata.c, it's
unlikely this will ever be done, but still good to note somewhere

diffstat:

 sys/dev/ata/TODO.ncq |   7 +------
 sys/dev/ic/mvsata.c  |  14 ++++++++++++--
 2 files changed, 13 insertions(+), 8 deletions(-)

diffs (49 lines):

diff -r a7d957893083 -r aed7c5368870 sys/dev/ata/TODO.ncq
--- a/sys/dev/ata/TODO.ncq      Mon Oct 22 20:23:28 2018 +0000
+++ b/sys/dev/ata/TODO.ncq      Mon Oct 22 20:30:52 2018 +0000
@@ -25,9 +25,4 @@
 
 implement DIOCGCACHE/DIOCCACHESYNC for ld@ataraid? just passthrough, like ccd
 
-MSI/MSI-X support for ahcisata(4), siisata(4) and mvsata(4)
-
-mvsata - move pci-specific code to the pci attach code
-
-mvsata(4) 64-bit DMA
-- at least with AHA1430SA does not really work, crash in mvsata_intr() on boot
+MSI/MSI-X support for ahcisata(4), siisata(4)
diff -r a7d957893083 -r aed7c5368870 sys/dev/ic/mvsata.c
--- a/sys/dev/ic/mvsata.c       Mon Oct 22 20:23:28 2018 +0000
+++ b/sys/dev/ic/mvsata.c       Mon Oct 22 20:30:52 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mvsata.c,v 1.43 2018/10/22 20:13:47 jdolecek Exp $     */
+/*     $NetBSD: mvsata.c,v 1.44 2018/10/22 20:30:52 jdolecek Exp $     */
 /*
  * Copyright (c) 2008 KIYOHARA Takashi
  * All rights reserved.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mvsata.c,v 1.43 2018/10/22 20:13:47 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mvsata.c,v 1.44 2018/10/22 20:30:52 jdolecek Exp $");
 
 #include "opt_mvsata.h"
 
@@ -58,6 +58,16 @@
 
 #include <dev/pci/pcidevs.h> /* XXX should not be here */
 
+/*
+ * Nice things to do:
+ *
+ * - MSI/MSI-X support - though on some models MSI actually doesn't work
+ *   even when hardware claims to support it, according to FreeBSD/OpenBSD
+ * - move pci-specific code to the pci attach code
+ * - mvsata(4) use 64-bit DMA on hardware which claims to support it
+ *   - e.g. AHA1430SA does not really work, crash in mvsata_intr() on boot
+ */
+
 #include <dev/ic/mvsatareg.h>
 #include <dev/ic/mvsatavar.h>
 



Home | Main Index | Thread Index | Old Index