Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb Skip urtwn_chip_stop for 88E family chips as we ...



details:   https://anonhg.NetBSD.org/src/rev/dc9b79f0db55
branches:  trunk
changeset: 365064:dc9b79f0db55
user:      jmcneill <jmcneill%NetBSD.org@localhost>
date:      Mon Jul 30 00:17:28 2018 +0000

description:
Skip urtwn_chip_stop for 88E family chips as we do for 92EU.

Doing "ifconfig urtwn0 down" with an RTL8188EU on Pinebook causes the
device to disappear from the built-in GL850G USB 2.0 hub. Since this
happens at reboot, an unplug/replug cycle is the only way to make the
device re-appear. Bypassing urtwn_chip_stop works around this issue.

diffstat:

 sys/dev/usb/if_urtwn.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r c45b3e16bf89 -r dc9b79f0db55 sys/dev/usb/if_urtwn.c
--- a/sys/dev/usb/if_urtwn.c    Sun Jul 29 22:46:13 2018 +0000
+++ b/sys/dev/usb/if_urtwn.c    Mon Jul 30 00:17:28 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_urtwn.c,v 1.61 2018/07/29 02:07:22 riastradh Exp $  */
+/*     $NetBSD: if_urtwn.c,v 1.62 2018/07/30 00:17:28 jmcneill Exp $   */
 /*     $OpenBSD: if_urtwn.c,v 1.42 2015/02/10 23:25:46 mpi Exp $       */
 
 /*-
@@ -25,7 +25,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_urtwn.c,v 1.61 2018/07/29 02:07:22 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_urtwn.c,v 1.62 2018/07/30 00:17:28 jmcneill Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -4968,7 +4968,8 @@
 
        DPRINTFN(DBG_FN, ("%s: %s\n", device_xname(sc->sc_dev), __func__));
 
-       if (ISSET(sc->chip, URTWN_CHIP_92EU))
+       if (ISSET(sc->chip, URTWN_CHIP_88E) ||
+           ISSET(sc->chip, URTWN_CHIP_92EU))
                return;
 
        mutex_enter(&sc->sc_write_mtx);



Home | Main Index | Thread Index | Old Index