Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/sdmmc Decrypt comment about the attach thread. No fu...



details:   https://anonhg.NetBSD.org/src/rev/28a7b1e9a2d8
branches:  trunk
changeset: 355045:28a7b1e9a2d8
user:      mlelstv <mlelstv%NetBSD.org@localhost>
date:      Mon Jul 10 10:35:07 2017 +0000

description:
Decrypt comment about the attach thread. No functional change.

diffstat:

 sys/dev/sdmmc/ld_sdmmc.c |  13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diffs (34 lines):

diff -r fc22a8c85b25 -r 28a7b1e9a2d8 sys/dev/sdmmc/ld_sdmmc.c
--- a/sys/dev/sdmmc/ld_sdmmc.c  Mon Jul 10 10:28:23 2017 +0000
+++ b/sys/dev/sdmmc/ld_sdmmc.c  Mon Jul 10 10:35:07 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ld_sdmmc.c,v 1.29 2017/07/08 18:38:57 jmcneill Exp $   */
+/*     $NetBSD: ld_sdmmc.c,v 1.30 2017/07/10 10:35:07 mlelstv Exp $    */
 
 /*
  * Copyright (c) 2008 KIYOHARA Takashi
@@ -28,7 +28,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ld_sdmmc.c,v 1.29 2017/07/08 18:38:57 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ld_sdmmc.c,v 1.30 2017/07/10 10:35:07 mlelstv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_sdmmc.h"
@@ -153,8 +153,13 @@
        ld->sc_discard = ld_sdmmc_discard;
 
        /*
-        * It is avoided that the error occurs when the card attaches it,
-        * when wedge is supported.
+        * Defer attachment of ld + disk subsystem to a thread.
+        *
+        * This is necessary because wedge autodiscover needs to
+        * open and call into the ld driver, which could deadlock
+        * when the sdmmc driver isn't ready in early bootstrap.
+        *
+        * Don't mark thread as MPSAFE to keep aprint output sane.
         */
        config_pending_incr(self);
        if (kthread_create(PRI_NONE, 0, NULL,



Home | Main Index | Thread Index | Old Index