Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/tests/lib/libc/gen remove exect, it will not be fixed and it...



details:   https://anonhg.NetBSD.org/src/rev/6eec8cb12b1e
branches:  trunk
changeset: 351299:6eec8cb12b1e
user:      christos <christos%NetBSD.org@localhost>
date:      Thu Feb 09 03:27:07 2017 +0000

description:
remove exect, it will not be fixed and it will be removed.

diffstat:

 tests/lib/libc/gen/Makefile        |   3 +-
 tests/lib/libc/gen/exect/Makefile  |  15 ------
 tests/lib/libc/gen/exect/t_exect.c |  90 --------------------------------------
 3 files changed, 1 insertions(+), 107 deletions(-)

diffs (128 lines):

diff -r 11c080633068 -r 6eec8cb12b1e tests/lib/libc/gen/Makefile
--- a/tests/lib/libc/gen/Makefile       Thu Feb 09 03:24:05 2017 +0000
+++ b/tests/lib/libc/gen/Makefile       Thu Feb 09 03:27:07 2017 +0000
@@ -1,10 +1,9 @@
-# $NetBSD: Makefile,v 1.50 2016/12/09 06:12:02 kamil Exp $
+# $NetBSD: Makefile,v 1.51 2017/02/09 03:27:07 christos Exp $
 
 .include <bsd.own.mk>
 
 TESTSDIR=      ${TESTSBASE}/lib/libc/gen
 
-TESTS_SUBDIRS= exect
 TESTS_SUBDIRS+=        execve
 TESTS_SUBDIRS+=        posix_spawn
 
diff -r 11c080633068 -r 6eec8cb12b1e tests/lib/libc/gen/exect/Makefile
--- a/tests/lib/libc/gen/exect/Makefile Thu Feb 09 03:24:05 2017 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,15 +0,0 @@
-# $NetBSD: Makefile,v 1.1 2016/12/09 04:00:36 kamil Exp $
-
-NOMAN=         # defined
-WARNS=4
-
-.include <bsd.own.mk>
-
-TESTSDIR=      ${TESTSBASE}/lib/libc/gen/exect
-
-TESTS_C=       t_exect
-
-BINDIR=                ${TESTSDIR}
-SCRIPTSDIR=    ${TESTSDIR}
-
-.include <bsd.test.mk>
diff -r 11c080633068 -r 6eec8cb12b1e tests/lib/libc/gen/exect/t_exect.c
--- a/tests/lib/libc/gen/exect/t_exect.c        Thu Feb 09 03:24:05 2017 +0000
+++ /dev/null   Thu Jan 01 00:00:00 1970 +0000
@@ -1,90 +0,0 @@
-/*     $NetBSD: t_exect.c,v 1.6 2016/12/12 10:34:55 joerg Exp $        */
-
-/*-
- * Copyright (c) 2014 The NetBSD Foundation, Inc.
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
- * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
- * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
- * POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include <atf-c.h>
-
-#include <errno.h>
-#include <signal.h>
-#include <stddef.h>
-#include <stdio.h>
-#include <unistd.h>
-
-ATF_TC(t_exect_null);
-
-ATF_TC_HEAD(t_exect_null, tc)
-{
-       atf_tc_set_md_var(tc, "descr",
-           "Tests an empty exect(2) executing");
-}
-
-static volatile sig_atomic_t caught = 0;
-
-static void
-sigtrap_handler(int sig, siginfo_t *info, void *ctx)
-{
-       ATF_REQUIRE_EQ(sig, SIGTRAP);
-       ATF_REQUIRE_EQ(info->si_code, TRAP_TRACE);
-
-       ++caught;
-}
-
-ATF_TC_BODY(t_exect_null, tc)
-{
-       struct sigaction act;
-
-       /*
-        * Currently exect(3) is misdesigned -- see PR port-amd64/51700 and it
-        * needs to be redone from scratch.
-        *
-        * This test affects amd64 releng machines causing tests to hang or
-        * fail. As there is little point to test interface that is still not,
-        * designed and implemented and is breaking tests - skip it
-        * unconditionally for all ports.
-        */
-       /* Prevent static analysis from requiring t_exec_null to be __dead. */
-       if (!caught) 
-               atf_tc_skip("exect(3) misdesigned and hangs - PR port-amd64/51700");
-
-       ATF_REQUIRE(sigemptyset(&act.sa_mask) == 0);
-       act.sa_sigaction = sigtrap_handler;
-       act.sa_flags = SA_SIGINFO;
-
-       ATF_REQUIRE(sigaction(SIGTRAP, &act, 0) == 0);
-
-       ATF_REQUIRE_ERRNO(EFAULT, exect(NULL, NULL, NULL) == -1);
-
-       ATF_REQUIRE_EQ_MSG(caught, 1, "expected caught (1) != received (%d)",
-           (int)caught);
-}
-
-ATF_TP_ADD_TCS(tp)
-{
-       ATF_TP_ADD_TC(tp, t_exect_null);
-
-       return atf_no_error();
-}



Home | Main Index | Thread Index | Old Index