Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/i386/stand/mbr Drop explicit loop prefix. GAS doesn...



details:   https://anonhg.NetBSD.org/src/rev/06e2c04b19f8
branches:  trunk
changeset: 359613:06e2c04b19f8
user:      joerg <joerg%NetBSD.org@localhost>
date:      Sat Feb 17 13:54:52 2018 +0000

description:
Drop explicit loop prefix. GAS doesn't care and LLVM doesn't support it.
Drop the need for assembling with GAS. While LLVM is using a suboptimal
encoding of for hard-coded memory writes, it shouldn't affect
functionality. It just wastes three bytes with extra prefixes.

diffstat:

 sys/arch/i386/stand/mbr/gptmbr.S        |  4 ++--
 sys/arch/i386/stand/mbr/gptmbr/Makefile |  4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

diffs (36 lines):

diff -r ccbce672bdb0 -r 06e2c04b19f8 sys/arch/i386/stand/mbr/gptmbr.S
--- a/sys/arch/i386/stand/mbr/gptmbr.S  Sat Feb 17 13:01:23 2018 +0000
+++ b/sys/arch/i386/stand/mbr/gptmbr.S  Sat Feb 17 13:54:52 2018 +0000
@@ -160,7 +160,7 @@
 get_ptab:
        call    read_sector
        call    inc64
-       loopw   get_ptab
+       loop    get_ptab
 
        /* Find the boot partition */
        xorw    %si,%si                 /* Nothing found yet */
@@ -182,7 +182,7 @@
        movw    %di,%si
 not_this:
        addw    %ax,%di
-       loopw   find_part
+       loop    find_part
 
        andw    %si,%si
        jnz     found_part
diff -r ccbce672bdb0 -r 06e2c04b19f8 sys/arch/i386/stand/mbr/gptmbr/Makefile
--- a/sys/arch/i386/stand/mbr/gptmbr/Makefile   Sat Feb 17 13:01:23 2018 +0000
+++ b/sys/arch/i386/stand/mbr/gptmbr/Makefile   Sat Feb 17 13:54:52 2018 +0000
@@ -1,10 +1,8 @@
-#      $NetBSD: Makefile,v 1.3 2011/09/21 18:15:59 jakllsch Exp $
+#      $NetBSD: Makefile,v 1.4 2018/02/17 13:54:52 joerg Exp $
 
 PROG=          gptmbr.bin
 SRCS=          gptmbr.S
 
-AFLAGS.gptmbr.S= ${${ACTIVE_CC} == "clang":?-no-integrated-as:}
-
 .include <../Makefile.mbr>
 
 LOADADDR=      0x600



Home | Main Index | Thread Index | Old Index