[src/trunk]: src/bin/sh In addition to previous the which fixed a (harmless) ...

[kre <kre%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/4e371c3edba9
branches:  trunk
changeset: 358457:4e371c3edba9
user:      kre <kre%NetBSD.org@localhost>
date:      Sat Dec 30 23:24:19 2017 +0000

description:
In addition to previous the which fixed a (harmless) MSAN detected ref
of uninit'd field also fix a couple more (still harmless) related
technical C usage bugs.

Explaining why these issues were harmless would take too long to include here.

diffstat:

 bin/sh/jobs.c |  12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diffs (33 lines):

diff -r f895898af363 -r 4e371c3edba9 bin/sh/jobs.c
--- a/bin/sh/jobs.c     Sat Dec 30 22:02:34 2017 +0000
+++ b/bin/sh/jobs.c     Sat Dec 30 23:24:19 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: jobs.c,v 1.97 2017/12/30 20:42:28 christos Exp $       */
+/*     $NetBSD: jobs.c,v 1.98 2017/12/30 23:24:19 kre Exp $    */
 
 /*-
  * Copyright (c) 1991, 1993
@@ -37,7 +37,7 @@
 #if 0
 static char sccsid[] = "@(#)jobs.c     8.5 (Berkeley) 5/4/95";
 #else
-__RCSID("$NetBSD: jobs.c,v 1.97 2017/12/30 20:42:28 christos Exp $");
+__RCSID("$NetBSD: jobs.c,v 1.98 2017/12/30 23:24:19 kre Exp $");
 #endif
 #endif /* not lint */
 
@@ -465,9 +465,11 @@
                        fmtstr(s, 16, "[%ld] %c ",
                                (long)(jp - jobtab + 1),
 #if JOBS
-                               jp == jobtab + curjob ? '+' :
-                               curjob != -1 && jp == jobtab +
-                                           jobtab[curjob].prev_job ? '-' :
+                               jp - jobtab == curjob ?
+                                                                         '+' :
+                               curjob != -1 &&
+                                   jp - jobtab == jobtab[curjob].prev_job ?
+                                                                         '-' :
 #endif
                                ' ');
                else