Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/rump Disable NULL pointer check deletion like we do for ...



details:   https://anonhg.NetBSD.org/src/rev/28f9de0c02ba
branches:  trunk
changeset: 320869:28f9de0c02ba
user:      christos <christos%NetBSD.org@localhost>
date:      Sat Mar 03 22:46:30 2018 +0000

description:
Disable NULL pointer check deletion like we do for the kernel in
src/sys/conf/Makefile.kern.inc. This is the same code we are compiling after
all and it has the same issues.

diffstat:

 sys/rump/Makefile.rump |  7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diffs (21 lines):

diff -r 33aba16c6368 -r 28f9de0c02ba sys/rump/Makefile.rump
--- a/sys/rump/Makefile.rump    Sat Mar 03 19:26:12 2018 +0000
+++ b/sys/rump/Makefile.rump    Sat Mar 03 22:46:30 2018 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile.rump,v 1.123 2018/01/18 00:32:49 mrg Exp $
+#      $NetBSD: Makefile.rump,v 1.124 2018/03/03 22:46:30 christos Exp $
 #
 
 .if !defined(_RUMP_MK)
@@ -19,6 +19,11 @@
 CPPFLAGS+=     -D_RUMPKERNEL -I${RUMPTOP}/librump/rumpkern
 .endif
 
+# We are compiling the kernel code with no-delete-null-pointer-checks,
+# and compiling without it, causes issues at least on sh3 by adding
+# aborts after kern_assert on NULL pointer checks.
+CFLAGS+=    ${${ACTIVE_CC} == "gcc":? -fno-delete-null-pointer-checks :}
+
 # Define baseline cpu for mips ports, required for
 # rumpcomp_sync_icache() hypercall.
 .if !empty(MACHINE_ARCH:Mmips*)



Home | Main Index | Thread Index | Old Index