Re: Some SA11x0 diffs

[Robert Swindells <rjs%fdy2.demon.co.uk@localhost>]

ober%linbsd.org@localhost wrote:
>Zaurus boots this up fine.
>However on removing an unmount CF card it panics with:
>
>panic: config_detach: forced detach of wdc1 failed(45)
>Stopped in pid 0.30 (system) at netbsd:cpu_Debugger+0x4 bx r14
>config_Detach+0xc
>pcmcia_card_detach+0xc
>pcapcic_event_thread+0xc
>Bad frame pointer 0xc01ccf3c
>
>If you need a full trace let me know
>and I can hook up the console cable.

I'm fairly sure that my patch doesn't touch the code path that would be
executed here. A full trace would be helpful.

I did spot one place in pxa2x0_pcic.c that still used struct device though.

Index: pxa2x0_pcic.c
===================================================================
RCS file: /cvsroot/src/sys/arch/arm/xscale/pxa2x0_pcic.c,v
retrieving revision 1.8
diff -u -r1.8 pxa2x0_pcic.c
--- pxa2x0_pcic.c       2 Mar 2009 10:17:58 -0000       1.8
+++ pxa2x0_pcic.c       24 May 2009 11:31:04 -0000
@@ -44,7 +44,7 @@
 
 static int     pxapcic_print(void *, const char *);
 
-static void    pxapcic_doattach(struct device *);
+static void    pxapcic_doattach(device_t);
 
 static void    pxapcic_event_thread(void *);
 static void    pxapcic_event_process(struct pxapcic_socket *);
@@ -398,7 +398,7 @@
 }
 
 void
-pxapcic_doattach(struct device *self)
+pxapcic_doattach(device_t self)
 {
        struct pxapcic_softc *sc = device_private(self);
        struct pxapcic_socket *sock;