Re: xentools build failure (ocaml related)

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Tue, Jan 05, 2021 at 08:11:00PM +0000, Chavdar Ivanov wrote:
> > > Is this a known issue? Should I send-pr?
> >
> > Kown issue, I don't know how to fix yet, other than rebuilding ocaml
> > without -force-safe-string ...
> 
> FWIW I just finished a build of the latest xentools 4.13. I had to
> manually do the following:
> 
> 1. Patch string.c from seabios  (earlier suggestion):
> 
> diff -u work/seabios-rel-1.12.1/src/string.c.orig
> work/seabios-rel-1.12.1/src/string.c
> --- work/seabios-rel-1.12.1/src/string.c.orig     2019-03-14
> 12:11:53.000000000 +0000
> +++ work/seabios-rel-1.12.1/src/string.c        2021-01-05
> 19:49:00.426549269 +0000
> @@ -152,9 +152,6 @@
>  void *
>  #undef memcpy
>  memcpy(void *d1, const void *s1, size_t len)
> -#if MODESEGMENT == 0
> -#define memcpy __builtin_memcpy
> -#endif
>  {
>      SET_SEG(ES, GET_SEG(SS));
>      void *d = d1;
> 

I don't undertand why you need this. If certainly builds fine for me without

> 
> 2. Get rid of "-unsafe-string" from work/xen-4.13.2/tools/ocaml/common.make
> 
> 3. Add "-Wno-error=discarded-qualifiers" to the Makefile.rules file.
> 
> No idea if the resulting kit will work, though. I haven't tried xen
> for a while under NetBSD; one of these days, perhaps...

it works, I committed these fixes.
thanks !

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--