Port-xen archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: interrupt cleanup #2



Manuel Bouyer <bouyer%antioche.eu.org@localhost> writes:

> On Tue, Aug 28, 2018 at 10:44:32AM +0530, Cherry G.Mathew wrote:
>> [...]
>> +	extern int pirq_interrupt(void *);
>> +	if (event_set_handler(evtchn, pirq_interrupt, pih, level,
>> +		intrstr, xname) != 0) {
>> +		kmem_free(pih, sizeof(struct pintrhand));
>> +		return NULL;
>> +	}
>
> Please don't do this. pirq_interrupt() should be declared in a header file.

Hi Manuel,

I'm trying to remove pirq_interrupt() eventually. Let me send the rest
of the patches so you can comment with the full pictures.

-- 
~cherry


Home | Main Index | Thread Index | Old Index