Subject: xen/clock.c:get_tsc_offset_ns
To: None <port-xen@NetBSD.org>
From: Jed Davis <jdev@panix.com>
List: port-xen
Date: 01/12/2006 21:00:34
I notice that the static function get_tsc_offset_ns in xen/clock.c
multiplies a uint32_t by 1000000000, which looks to me as though it'll
pretty much always overflow (if more than 4 cycles have passed since
the last call to get_time_values_from_xen, it seems).  So, two questions:

1) Should that be 1000000000ULL instead? 
2) If so, how much is this breaking?

-- 
(let ((C call-with-current-continuation)) (apply (lambda (x y) (x y)) (map
((lambda (r) ((C C) (lambda (s) (r (lambda l (apply (s s) l))))))  (lambda
(f) (lambda (l) (if (null? l) C (lambda (k) (display (car l)) ((f (cdr l))
(C k)))))))    '((#\J #\d #\D #\v #\s) (#\e #\space #\a #\i #\newline)))))