Subject: Re: Minor precedence issues in pmap_remap_pages()?
To: None <port-xen@NetBSD.org>
From: Jed Davis <jdev@panix.com>
List: port-xen
Date: 11/16/2005 17:08:53
YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp> writes:

>> > diff -u -r1.8.2.3 pmap.c
>> > --- sys/arch/xen/i386/pmap.c    6 Jun 2005 12:16:10 -0000       1.8.2.3
>> > +++ sys/arch/xen/i386/pmap.c    21 Jul 2005 03:55:43 -0000
>> > @@ -3715,7 +3715,7 @@
>> >                  * wired count might change...
>> >                  */
>> >                 pmap->pm_stats.wired_count +=
>> > -                   ((npte & PG_W) ? 1 : 0 - (opte & PG_W) ? 1 : 0);
>> > +                   ((npte & PG_W) ? 1 : 0) - ((opte & PG_W) ? 1 : 0);
[snip]
> please go ahead.  don't forget to fix i386 version as well.

pmap_remap_pages is Xen-specific; it's for mapping foreign domains'
pages, as the name entirely fails to suggest.

--Jed