Subject: Re: Problem with dev/qbus/if_qe.c
To: None <ragge@ludd.luth.se>
From: James Chacon <jchacon@genuity.net>
List: port-vax
Date: 01/28/2003 17:39:45
I reread the diff..I'm not sure how this compiled in the first place. It
really does seem to need the 2nd patch as well.

James

RCS file: /cvsroot/src/sys/dev/qbus/if_qe.c,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -r1.55 -r1.56
--- sys/dev/qbus/if_qe.c        2002/10/02 16:52:28     1.55
+++ sys/dev/qbus/if_qe.c        2003/01/15 22:10:25     1.56
@@ -494,6 +494,8 @@
                                orword |= QE_ODDBEGIN;
                        if ((buffer + len) & 1)
                                orword |= QE_ODDEND;
+                       if (len > m0->m_len) {
+                               memset(buffer + m0->m_len, 0, len - m0->m_len);
                        qc->qc_xmit[idx].qe_buf_len = -(len/2);
                        qc->qc_xmit[idx].qe_addr_lo = LOWORD(buffer);
                        qc->qc_xmit[idx].qe_addr_hi = HIWORD(buffer);

>
>Something has become really broken in that file after the pullup of
>Manuel Bouyer's fix of the "send random data" problem. Probably
>CVS has trashed the file, or something; please recheck the merge.
>
>-- Ragge
>
>> Hi,
>> 
>> Does someone have the time to quickly look at this? This is fresh off of
>> the cvs server - I'm trying to build 1.6.1_RC1 as quickly as possible so I
>> can get the VAX started on building the X sets.
>> 
>> Thanks,
>> John Klos
>> Sixgirls Computing Labs
>> 
>> 
>> /usr/vax-obj/tools/tools.NetBSD-1.6_STABLE-i386/bin/vax--netbsdelf-gcc
>> -mno-asm-pic -ffreestanding  -O2 -Werror -Wall -Wno-main
>> -Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes
>> -Wstrict-prototypes -Wno-uninitialized  -D_VAX_INLINE_ -I.
>> -I/usr/src/sys/arch -I/usr/src/sys -nostdinc -DLKM -DMAXUSERS=8 -D_KERNEL
>> -D_KERNEL_OPT   -c /usr/src/sys/dev/qbus/if_qe.c
>> cc1: warnings being treated as errors
>> /usr/src/sys/dev/qbus/if_qe.c: In function `qestart':
>> /usr/src/sys/dev/qbus/if_qe.c:499: warning: passing arg 1 of
>> `__builtin_memset' makes pointer from integer without a cast
>> /usr/src/sys/dev/qbus/if_qe.c:535: parse error before `static'
>> /usr/src/sys/dev/qbus/if_qe.c:551: `status1' undeclared (first use in this
>> function)
>> /usr/src/sys/dev/qbus/if_qe.c:551: (Each undeclared identifier is reported
>> only once
>> /usr/src/sys/dev/qbus/if_qe.c:551: for each function it appears in.)
>> /usr/src/sys/dev/qbus/if_qe.c:552: `status2' undeclared (first use in this
>> function)
>> /usr/src/sys/dev/qbus/if_qe.c: At top level:
>> /usr/src/sys/dev/qbus/if_qe.c:111: warning: `qeintr' used but never
>> defined
>> *** Error code 1
>> 
>> Stop.
>> 
>
>
>