Subject: Re: Bug in 1.2 build.
To: Robin Birch <robin@falstaf.demon.co.uk>
From: Mats O Jansson <maja@celsiustech.se>
List: port-vax
Date: 10/10/1996 08:51:03
On Fri, 31 Dec 1999, Robin Birch wrote:

> 
> Dear All,
> I think there is a bug in the libm Makefile for 1.2.  I have attached a
> modified one that appears to work.  This was discovered when doing a make 
> build on 1.2 sources as taken from the server.
> 
> The makefile did not correctly take account of the assembler files used
> in a vax build.
>
I don't think your solution is a good one. If you look in the original 
Makefile the is a code segment which looks like

# Substitute common sources with any arch specific sources 
.for i in ${ARCH_SRCS}
    SRCS:=${SRCS:S/${i:S/.S/.c/}/$i/}
.endfor

This code is responsible for replacing .c modules with .S module in 
ARCH_SRCS. What I did in OpenBSD/vax was to add the following code to do
the same thing with modules in NOIEEE_ARCH: 

.if (${MACHINE_ARCH} == "vax")
.for i in ${NOIEEE_ARCH}
    SRCS:=${SRCS:S/${i:S/.S/.c/}/$i/}
.endfor
.endif

I'm not sure if the if-statement is neccesary, but I added it to be on 
the safe size.

> Can someone please check my work, put in a tidier fix if they have one,
> and get it into the current source tree as I don't know how to go about this
> 
> Cheers
> 

-moj

------------------------------------------------------------------------------
Mats O Jansson, CelsiusTech Systems, Jaerfaella, Sweden
email: maja@celsiustech.se (or moj@stacken.kth.se)