Subject: re: softintr(9) patch
To: Matt Fredette <fredette@theory.lcs.mit.edu>
From: matthew green <mrg@eterna.com.au>
List: port-sparc
Date: 12/06/2002 13:28:22
   
   Comments and/or "ok to commit" welcome.  Thanks!

+#define AUDIO_SET_SWINTR softintr_schedule(sc->sc_sicookie)

"yuck"  don't use local variables in macros.  same here:

+#define FD_SET_SWINTR softintr_schedule(fdc->sc_sicookie)       


make softintr_priority() an inline function or macro?  seems a waste of a
function call ...


i think the magma driver needs to be tested before this is commited, as well.


.mrg.